diff options
| author | Serhiy Storchaka <storchaka@gmail.com> | 2018-12-11 06:28:18 (GMT) |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2018-12-11 06:28:18 (GMT) |
| commit | bb86bf4c4eaa30b1f5192dab9f389ce0bb61114d (patch) | |
| tree | b9dbe54e2c1380294f3e2396450132d5b205af0a /Modules/_pickle.c | |
| parent | 7cf3d8e25174c8871883e42f3240fd7f01efd3a8 (diff) | |
| download | cpython-bb86bf4c4eaa30b1f5192dab9f389ce0bb61114d.zip cpython-bb86bf4c4eaa30b1f5192dab9f389ce0bb61114d.tar.gz cpython-bb86bf4c4eaa30b1f5192dab9f389ce0bb61114d.tar.bz2 | |
bpo-35444: Unify and optimize the helper for getting a builtin object. (GH-11047)
This speeds up pickling of some iterators.
This fixes also error handling in pickling methods when fail to
look up builtin "getattr".
Diffstat (limited to 'Modules/_pickle.c')
| -rw-r--r-- | Modules/_pickle.c | 8 |
1 files changed, 2 insertions, 6 deletions
diff --git a/Modules/_pickle.c b/Modules/_pickle.c index c4fe349..58cd09c 100644 --- a/Modules/_pickle.c +++ b/Modules/_pickle.c @@ -209,19 +209,15 @@ _Pickle_ClearState(PickleState *st) static int _Pickle_InitState(PickleState *st) { - PyObject *builtins; PyObject *copyreg = NULL; PyObject *compat_pickle = NULL; PyObject *codecs = NULL; PyObject *functools = NULL; + _Py_IDENTIFIER(getattr); - builtins = PyEval_GetBuiltins(); - if (builtins == NULL) - goto error; - st->getattr = PyDict_GetItemString(builtins, "getattr"); + st->getattr = _PyEval_GetBuiltinId(&PyId_getattr); if (st->getattr == NULL) goto error; - Py_INCREF(st->getattr); copyreg = PyImport_ImportModule("copyreg"); if (!copyreg) |