diff options
| author | Gregory P. Smith <greg@krypto.org> | 2013-12-01 03:04:00 (GMT) |
|---|---|---|
| committer | Gregory P. Smith <greg@krypto.org> | 2013-12-01 03:04:00 (GMT) |
| commit | 1c27e3c7fbf8ee33e20677558e7e394a1bdb70d0 (patch) | |
| tree | 343d58bb4fdf0404e2aea3db12a4280d0188fbed /Modules/_posixsubprocess.c | |
| parent | 2ccf8e969c5e870a6c416ac7970c9f94c0da86fd (diff) | |
| parent | 1eda9e7c3074bfe37674c8140b3d02bf94caf4f3 (diff) | |
| download | cpython-1c27e3c7fbf8ee33e20677558e7e394a1bdb70d0.zip cpython-1c27e3c7fbf8ee33e20677558e7e394a1bdb70d0.tar.gz cpython-1c27e3c7fbf8ee33e20677558e7e394a1bdb70d0.tar.bz2 | |
Fixes Issue #15798 - subprocess.Popen() no longer fails if file
descriptor 0, 1 or 2 is closed.
Diffstat (limited to 'Modules/_posixsubprocess.c')
| -rw-r--r-- | Modules/_posixsubprocess.c | 6 |
1 files changed, 1 insertions, 5 deletions
diff --git a/Modules/_posixsubprocess.c b/Modules/_posixsubprocess.c index a2d7022..fefd899 100644 --- a/Modules/_posixsubprocess.c +++ b/Modules/_posixsubprocess.c @@ -458,7 +458,7 @@ child_exec(char *const exec_array[], local_max_fd = max_fd; #endif /* TODO HP-UX could use pstat_getproc() if anyone cares about it. */ - _close_open_fd_range(3, local_max_fd, py_fds_to_keep); + _close_open_fd_range(0, local_max_fd, py_fds_to_keep); } /* This loop matches the Lib/os.py _execvpe()'s PATH search when */ @@ -535,10 +535,6 @@ subprocess_fork_exec(PyObject* self, PyObject *args) &restore_signals, &call_setsid, &preexec_fn)) return NULL; - if (close_fds && errpipe_write < 3) { /* precondition */ - PyErr_SetString(PyExc_ValueError, "errpipe_write must be >= 3"); - return NULL; - } if (PySequence_Length(py_fds_to_keep) < 0) { PyErr_SetString(PyExc_ValueError, "cannot get length of fds_to_keep"); return NULL; |