Apply two changes, systematically:

(1) Use PyErr_NewException("module.class", NULL, NULL) to create the
    exception object.

(2) Remove all calls to Py_FatalError(); instead, return or
    ignore the errors -- the import code now checks PyErr_Occurred()
    after calling a module's init function, so it's no longer a
    fatal error for the initialization to fail.

Also did some small cleanups, e.g. removed unnecessary test for
"already initialized" from initfpectl(), and unified
initposix()/initnt().

I haven't checked this very thoroughly, so while the changes are
pretty trivial -- beware of untested code!

1 files changed, 3 insertions, 3 deletions

diff --git a/Modules/bsddbmodule.c b/Modules/bsddbmodule.c
index 0c9915a..ee979b8 100644
--- a/Modules/bsddbmodule.c
+++ b/Modules/bsddbmodule.c
@@ -746,7 +746,7 @@ initbsddb() {
 	Bsddbtype.ob_type = &PyType_Type;
 	m = Py_InitModule("bsddb", bsddbmodule_methods);
 	d = PyModule_GetDict(m);
-	BsddbError = PyString_FromString("bsddb.error");
-	if (BsddbError == NULL || PyDict_SetItemString(d, "error", BsddbError))
-		Py_FatalError("can't define bsddb.error");
+	BsddbError = PyErr_NewException("bsddb.error", NULL, NULL);
+	if (BsddbError != NULL)
+		PyDict_SetItemString(d, "error", BsddbError);
 }