bpo-30600: Fix error messages (condition order in Argument Clinic) (#2051)

The function '_PyArg_ParseStack()' and
'_PyArg_UnpackStack' were failing (with error
"XXX() takes Y argument (Z given)") before
the function '_PyArg_NoStackKeywords()' was called.
Thus, the latter did not raise its more meaningful
error : "XXX() takes no keyword arguments".

1 files changed, 4 insertions, 4 deletions

diff --git a/Modules/clinic/_weakref.c.h b/Modules/clinic/_weakref.c.h
index d847867..139a0e1 100644
--- a/Modules/clinic/_weakref.c.h
+++ b/Modules/clinic/_weakref.c.h
@@ -50,12 +50,12 @@ _weakref__remove_dead_weakref(PyObject *module, PyObject **args, Py_ssize_t narg
     PyObject *dct;
     PyObject *key;
 
-    if (!_PyArg_ParseStack(args, nargs, "O!O:_remove_dead_weakref",
-        &PyDict_Type, &dct, &key)) {
+    if (!_PyArg_NoStackKeywords("_remove_dead_weakref", kwnames)) {
         goto exit;
     }
 
-    if (!_PyArg_NoStackKeywords("_remove_dead_weakref", kwnames)) {
+    if (!_PyArg_ParseStack(args, nargs, "O!O:_remove_dead_weakref",
+        &PyDict_Type, &dct, &key)) {
         goto exit;
     }
     return_value = _weakref__remove_dead_weakref_impl(module, dct, key);
@@ -63,4 +63,4 @@ _weakref__remove_dead_weakref(PyObject *module, PyObject **args, Py_ssize_t narg
 exit:
     return return_value;
 }
-/*[clinic end generated code: output=b686303486bdfefd input=a9049054013a1b77]*/
+/*[clinic end generated code: output=05ecbb46c85839a2 input=a9049054013a1b77]*/