diff options
| author | Hirokazu Yamamoto <ocean-city@m2.ccsnet.ne.jp> | 2009-03-03 07:49:01 (GMT) |
|---|---|---|
| committer | Hirokazu Yamamoto <ocean-city@m2.ccsnet.ne.jp> | 2009-03-03 07:49:01 (GMT) |
| commit | 8404749e4b65f23a7d84c3940ea061eee0b4b344 (patch) | |
| tree | d8082d486912a2af4485d4b47dceee81bc6a3f02 /Modules/md5module.c | |
| parent | 45ed72ddaf16c97237f2ad522959d6ffd8b40e2e (diff) | |
| download | cpython-8404749e4b65f23a7d84c3940ea061eee0b4b344.zip cpython-8404749e4b65f23a7d84c3940ea061eee0b4b344.tar.gz cpython-8404749e4b65f23a7d84c3940ea061eee0b4b344.tar.bz2 | |
Fixed memory leak on failure. This is related to issue5403 but won't crash on py3k.
Diffstat (limited to 'Modules/md5module.c')
| -rw-r--r-- | Modules/md5module.c | 9 |
1 files changed, 7 insertions, 2 deletions
diff --git a/Modules/md5module.c b/Modules/md5module.c index ac98433..6476bb7 100644 --- a/Modules/md5module.c +++ b/Modules/md5module.c @@ -526,18 +526,23 @@ MD5_new(PyObject *self, PyObject *args, PyObject *kwdict) if (data_obj) GET_BUFFER_VIEW_OR_ERROUT(data_obj, &buf); - if ((new = newMD5object()) == NULL) + if ((new = newMD5object()) == NULL) { + if (data_obj) + PyBuffer_Release(&buf); return NULL; + } md5_init(&new->hash_state); if (PyErr_Occurred()) { Py_DECREF(new); + if (data_obj) + PyBuffer_Release(&buf); return NULL; } if (data_obj) { md5_process(&new->hash_state, buf.buf, buf.len); - PyBuffer_Release(&buf); + PyBuffer_Release(&buf); } return (PyObject *)new; |