diff options
author | Gregory P. Smith <greg@mad-scientist.com> | 2009-02-12 07:35:29 (GMT) |
---|---|---|
committer | Gregory P. Smith <greg@mad-scientist.com> | 2009-02-12 07:35:29 (GMT) |
commit | 365a1864fd285fc6ee9d9fa1f8770b39d4dab830 (patch) | |
tree | 0fb2cf9664348d80caa3e3ace86b84aa2a3f9080 /Modules/md5module.c | |
parent | 3072921d0e668e890da1312e0f47f3e7e4854329 (diff) | |
download | cpython-365a1864fd285fc6ee9d9fa1f8770b39d4dab830.zip cpython-365a1864fd285fc6ee9d9fa1f8770b39d4dab830.tar.gz cpython-365a1864fd285fc6ee9d9fa1f8770b39d4dab830.tar.bz2 |
Fixes Issue #3745: Fix hashlib to always reject unicode and non
buffer-api supporting objects as input no matter how it was compiled
(built in implementations or external openssl library).
Diffstat (limited to 'Modules/md5module.c')
-rw-r--r-- | Modules/md5module.c | 17 |
1 files changed, 12 insertions, 5 deletions
diff --git a/Modules/md5module.c b/Modules/md5module.c index 3d54131..ac98433 100644 --- a/Modules/md5module.c +++ b/Modules/md5module.c @@ -17,6 +17,7 @@ /* MD5 objects */ #include "Python.h" +#include "hashlib.h" /* Some useful types */ @@ -411,11 +412,14 @@ PyDoc_STRVAR(MD5_update__doc__, static PyObject * MD5_update(MD5object *self, PyObject *args) { + PyObject *obj; Py_buffer buf; - if (!PyArg_ParseTuple(args, "s*:update", &buf)) + if (!PyArg_ParseTuple(args, "O:update", &obj)) return NULL; + GET_BUFFER_VIEW_OR_ERROUT(obj, &buf); + md5_process(&self->hash_state, buf.buf, buf.len); PyBuffer_Release(&buf); @@ -511,14 +515,17 @@ MD5_new(PyObject *self, PyObject *args, PyObject *kwdict) { static char *kwlist[] = {"string", NULL}; MD5object *new; + PyObject *data_obj = NULL; Py_buffer buf; - buf.buf = NULL; - if (!PyArg_ParseTupleAndKeywords(args, kwdict, "|s*:new", kwlist, - &buf)) { + if (!PyArg_ParseTupleAndKeywords(args, kwdict, "|O:new", kwlist, + &data_obj)) { return NULL; } + if (data_obj) + GET_BUFFER_VIEW_OR_ERROUT(data_obj, &buf); + if ((new = newMD5object()) == NULL) return NULL; @@ -528,7 +535,7 @@ MD5_new(PyObject *self, PyObject *args, PyObject *kwdict) Py_DECREF(new); return NULL; } - if (buf.buf) { + if (data_obj) { md5_process(&new->hash_state, buf.buf, buf.len); PyBuffer_Release(&buf); } |