diff options
| author | Amaury Forgeot d'Arc <amauryfa@gmail.com> | 2008-07-02 23:40:28 (GMT) |
|---|---|---|
| committer | Amaury Forgeot d'Arc <amauryfa@gmail.com> | 2008-07-02 23:40:28 (GMT) |
| commit | 968117e97462bf086d25efb9b1990521f42f3409 (patch) | |
| tree | ca10269fc4ab935110bc3365a44ff44c0231e980 /Modules/nismodule.c | |
| parent | 0bfac6e5d8671f21327b1a8413d68cf23285105f (diff) | |
| download | cpython-968117e97462bf086d25efb9b1990521f42f3409.zip cpython-968117e97462bf086d25efb9b1990521f42f3409.tar.gz cpython-968117e97462bf086d25efb9b1990521f42f3409.tar.bz2 | |
Try a blind fix to nismodule which fails on the solaris10 3.0 buildbot:
the GIL must be re-acquired in the callback function
Diffstat (limited to 'Modules/nismodule.c')
| -rw-r--r-- | Modules/nismodule.c | 13 |
1 files changed, 8 insertions, 5 deletions
diff --git a/Modules/nismodule.c b/Modules/nismodule.c index 0811430..9c1cd00 100644 --- a/Modules/nismodule.c +++ b/Modules/nismodule.c @@ -98,6 +98,7 @@ typedef int (*foreachfunc)(int, char *, int, char *, int, char *); struct ypcallback_data { PyObject *dict; int fix; + PyThreadState *state; }; static int @@ -109,6 +110,7 @@ nis_foreach (int instatus, char *inkey, int inkeylen, char *inval, PyObject *val; int err; + PyEval_RestoreThread(indata->state); if (indata->fix) { if (inkeylen > 0 && inkey[inkeylen-1] == '\0') inkeylen--; @@ -127,10 +129,11 @@ nis_foreach (int instatus, char *inkey, int inkeylen, char *inval, err = PyDict_SetItem(indata->dict, key, val); Py_DECREF(key); Py_DECREF(val); - if (err != 0) { + if (err != 0) PyErr_Clear(); - return 1; - } + indata->state = PyEval_SaveThread(); + if (err != 0) + return 1; return 0; } return 1; @@ -206,9 +209,9 @@ nis_cat (PyObject *self, PyObject *args, PyObject *kwdict) data.dict = dict; map = nis_mapname (map, &data.fix); cb.data = (char *)&data; - Py_BEGIN_ALLOW_THREADS + data.state = PyEval_SaveThread(); err = yp_all (domain, map, &cb); - Py_END_ALLOW_THREADS + PyEval_RestoreThread(data.state); if (err != 0) { Py_DECREF(dict); return nis_error(err); |