diff options
| author | Zackery Spytz <zspytz@gmail.com> | 2018-12-08 14:16:55 (GMT) |
|---|---|---|
| committer | Serhiy Storchaka <storchaka@gmail.com> | 2018-12-08 14:16:55 (GMT) |
| commit | 99d56b53560b3867844472ae381fb3f858760621 (patch) | |
| tree | f81865ef12567f144d7eaf3adf8b61c136945a55 /Modules/readline.c | |
| parent | f05df0a4b679d0acfd0b1fe6187ba2d553b37afa (diff) | |
| download | cpython-99d56b53560b3867844472ae381fb3f858760621.zip cpython-99d56b53560b3867844472ae381fb3f858760621.tar.gz cpython-99d56b53560b3867844472ae381fb3f858760621.tar.bz2 | |
bpo-35441: Remove dead and buggy code related to PyList_SetItem(). (GH-11033)
In _localemodule.c and selectmodule.c, remove dead code that would
cause double decrefs if run.
In addition, replace PyList_SetItem() with PyList_SET_ITEM() in cases
where a new list is populated and there is no possibility of an error.
In addition, check if the list changed size in the loop in array_array_fromlist().
Diffstat (limited to 'Modules/readline.c')
| -rw-r--r-- | Modules/readline.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/Modules/readline.c b/Modules/readline.c index 7f366aa..57335fe 100644 --- a/Modules/readline.c +++ b/Modules/readline.c @@ -936,8 +936,7 @@ on_completion_display_matches_hook(char **matches, s = decode(matches[i+1]); if (s == NULL) goto error; - if (PyList_SetItem(m, i, s) == -1) - goto error; + PyList_SET_ITEM(m, i, s); } sub = decode(matches[0]); r = PyObject_CallFunction(readlinestate_global->completion_display_matches_hook, |