diff options
| author | Antoine Pitrou <solipsis@pitrou.net> | 2012-11-01 19:13:54 (GMT) |
|---|---|---|
| committer | Antoine Pitrou <solipsis@pitrou.net> | 2012-11-01 19:13:54 (GMT) |
| commit | e4ad37e50efadc319d6c1089222f552dfcbf76ee (patch) | |
| tree | b64936a5fbbdd7b21553261ebebd3ad09bf721ce /Modules/selectmodule.c | |
| parent | 9f69e79c450c3c17172046f937941e6df1802a6d (diff) | |
| download | cpython-e4ad37e50efadc319d6c1089222f552dfcbf76ee.zip cpython-e4ad37e50efadc319d6c1089222f552dfcbf76ee.tar.gz cpython-e4ad37e50efadc319d6c1089222f552dfcbf76ee.tar.bz2 | |
Issue #16230: Fix a crash in select.select() when one the lists changes size while iterated on.
Patch by Serhiy Storchaka.
Diffstat (limited to 'Modules/selectmodule.c')
| -rw-r--r-- | Modules/selectmodule.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/Modules/selectmodule.c b/Modules/selectmodule.c index 98b3108..0736215 100644 --- a/Modules/selectmodule.c +++ b/Modules/selectmodule.c @@ -83,7 +83,7 @@ seq2set(PyObject *seq, fd_set *set, pylist fd2obj[FD_SETSIZE + 1]) { int max = -1; int index = 0; - Py_ssize_t i, len = -1; + Py_ssize_t i; PyObject* fast_seq = NULL; PyObject* o = NULL; @@ -94,9 +94,7 @@ seq2set(PyObject *seq, fd_set *set, pylist fd2obj[FD_SETSIZE + 1]) if (!fast_seq) return -1; - len = PySequence_Fast_GET_SIZE(fast_seq); - - for (i = 0; i < len; i++) { + for (i = 0; i < PySequence_Fast_GET_SIZE(fast_seq); i++) { SOCKET v; /* any intervening fileno() calls could decr this refcnt */ |