diff options
| author | Charles-François Natali <neologix@free.fr> | 2011-08-28 15:51:43 (GMT) |
|---|---|---|
| committer | Charles-François Natali <neologix@free.fr> | 2011-08-28 15:51:43 (GMT) |
| commit | aa26b275034c07784c4d64e9a2bc26c742577327 (patch) | |
| tree | d331c0e5f2dd0fc0f754ffebaf9ebb9e5c4f7958 /Modules/socketmodule.c | |
| parent | 524148ad7a3e5420abf867b1e30017b5ca2311a4 (diff) | |
| download | cpython-aa26b275034c07784c4d64e9a2bc26c742577327.zip cpython-aa26b275034c07784c4d64e9a2bc26c742577327.tar.gz cpython-aa26b275034c07784c4d64e9a2bc26c742577327.tar.bz2 | |
Issue #12287: Fix a stack corruption in ossaudiodev module when the FD is
greater than FD_SETSIZE.
Diffstat (limited to 'Modules/socketmodule.c')
| -rw-r--r-- | Modules/socketmodule.c | 12 |
1 files changed, 4 insertions, 8 deletions
diff --git a/Modules/socketmodule.c b/Modules/socketmodule.c index fcdbf8a..d3e5c75 100644 --- a/Modules/socketmodule.c +++ b/Modules/socketmodule.c @@ -455,18 +455,14 @@ static PyTypeObject sock_type; #include <sys/poll.h> #endif -#ifdef Py_SOCKET_FD_CAN_BE_GE_FD_SETSIZE -/* Platform can select file descriptors beyond FD_SETSIZE */ -#define IS_SELECTABLE(s) 1 -#elif defined(HAVE_POLL) +#ifdef HAVE_POLL /* Instead of select(), we'll use poll() since poll() works on any fd. */ #define IS_SELECTABLE(s) 1 /* Can we call select() with this socket without a buffer overrun? */ #else -/* POSIX says selecting file descriptors beyond FD_SETSIZE - has undefined behaviour. If there's no timeout left, we don't have to - call select, so it's a safe, little white lie. */ -#define IS_SELECTABLE(s) ((s)->sock_fd < FD_SETSIZE || s->sock_timeout <= 0.0) +/* If there's no timeout left, we don't have to call select, so it's a safe, + * little white lie. */ +#define IS_SELECTABLE(s) (_PyIsSelectable_fd((s)->sock_fd) || (s)->sock_timeout <= 0.0) #endif static PyObject* |