diff options
| author | Gregory P. Smith <greg@mad-scientist.com> | 2007-09-09 23:36:46 (GMT) |
|---|---|---|
| committer | Gregory P. Smith <greg@mad-scientist.com> | 2007-09-09 23:36:46 (GMT) |
| commit | e9fef694b4929d535a7c12480b5adae28d394d79 (patch) | |
| tree | df0768f00f9ca6050ced7890b20f32175d488546 /Modules | |
| parent | f80578548d46dbe6dad87b8b8f1ac0002bf6aef8 (diff) | |
| download | cpython-e9fef694b4929d535a7c12480b5adae28d394d79.zip cpython-e9fef694b4929d535a7c12480b5adae28d394d79.tar.gz cpython-e9fef694b4929d535a7c12480b5adae28d394d79.tar.bz2 | |
Change socket.error to inherit from IOError rather than being a stand
alone class. This addresses the primary concern in
http://bugs.python.org/issue1706815
python-dev discussion here:
http://mail.python.org/pipermail/python-dev/2007-July/073749.html
I chose IOError rather than EnvironmentError as the base class since
socket objects are often used as transparent duck typed file objects
in code already prepared to deal with IOError exceptions.
also a minor fix:
urllib2 - fix a couple places where IOError was raised rather than URLError.
for better or worse, URLError already inherits from IOError so
this won't break any existing code.
test_urllib2net - replace bad ftp urls.
Diffstat (limited to 'Modules')
| -rw-r--r-- | Modules/socketmodule.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/Modules/socketmodule.c b/Modules/socketmodule.c index d319ca3..410398e 100644 --- a/Modules/socketmodule.c +++ b/Modules/socketmodule.c @@ -4280,7 +4280,8 @@ init_socket(void) if (m == NULL) return; - socket_error = PyErr_NewException("socket.error", NULL, NULL); + socket_error = PyErr_NewException("socket.error", + PyExc_IOError, NULL); if (socket_error == NULL) return; PySocketModuleAPI.error = socket_error; |