diff options
author | Gregory P. Smith <greg@krypto.org> | 2013-12-01 08:13:35 (GMT) |
---|---|---|
committer | Gregory P. Smith <greg@krypto.org> | 2013-12-01 08:13:35 (GMT) |
commit | 54532c9742523814bbc43ccbd1a4560ec3d449d3 (patch) | |
tree | 9a56def10252b7ab1e154db3f23c64a0aa5481f3 /Modules | |
parent | 1c27e3c7fbf8ee33e20677558e7e394a1bdb70d0 (diff) | |
parent | 361e30c17a7973874334597903afb3ba5a477f49 (diff) | |
download | cpython-54532c9742523814bbc43ccbd1a4560ec3d449d3.zip cpython-54532c9742523814bbc43ccbd1a4560ec3d449d3.tar.gz cpython-54532c9742523814bbc43ccbd1a4560ec3d449d3.tar.bz2 |
Undo supposed fix for Issue #15798 until I understand why this is
causing test_multiprocessing_forkserver and test_multiprocessing_spawn
failures on head (3.4).
Diffstat (limited to 'Modules')
-rw-r--r-- | Modules/_posixsubprocess.c | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/Modules/_posixsubprocess.c b/Modules/_posixsubprocess.c index fefd899..a2d7022 100644 --- a/Modules/_posixsubprocess.c +++ b/Modules/_posixsubprocess.c @@ -458,7 +458,7 @@ child_exec(char *const exec_array[], local_max_fd = max_fd; #endif /* TODO HP-UX could use pstat_getproc() if anyone cares about it. */ - _close_open_fd_range(0, local_max_fd, py_fds_to_keep); + _close_open_fd_range(3, local_max_fd, py_fds_to_keep); } /* This loop matches the Lib/os.py _execvpe()'s PATH search when */ @@ -535,6 +535,10 @@ subprocess_fork_exec(PyObject* self, PyObject *args) &restore_signals, &call_setsid, &preexec_fn)) return NULL; + if (close_fds && errpipe_write < 3) { /* precondition */ + PyErr_SetString(PyExc_ValueError, "errpipe_write must be >= 3"); + return NULL; + } if (PySequence_Length(py_fds_to_keep) < 0) { PyErr_SetString(PyExc_ValueError, "cannot get length of fds_to_keep"); return NULL; |