diff options
| author | Miss Islington (bot) <31488909+miss-islington@users.noreply.github.com> | 2024-06-10 10:18:18 (GMT) |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-06-10 10:18:18 (GMT) |
| commit | 14ff4c979c8564376707de4b5a84dd3e4fcb5d1d (patch) | |
| tree | 62d1f88d0f9335d0583fe27a13cde8074f0e63b0 /Modules | |
| parent | 03cd44759f8e5faaa154628e196860255d87bddd (diff) | |
| download | cpython-14ff4c979c8564376707de4b5a84dd3e4fcb5d1d.zip cpython-14ff4c979c8564376707de4b5a84dd3e4fcb5d1d.tar.gz cpython-14ff4c979c8564376707de4b5a84dd3e4fcb5d1d.tar.bz2 | |
[3.13] gh-120155: Fix Coverity issue in zoneinfo load_data() (GH-120232) (#120310)
gh-120155: Fix Coverity issue in zoneinfo load_data() (GH-120232)
Declare the 'rv' varaible at the top of the load_data() function to
make sure that it's initialized before the first 'goto error' which
uses 'rv' (return rv).
Fix the Coverity issue:
Error: UNINIT (CWE-457):
Python-3.12.2/Modules/_zoneinfo.c:1233:5: skipped_decl: Jumping over declaration of ""rv"".
Python-3.12.2/Modules/_zoneinfo.c:1284:5: uninit_use: Using uninitialized value ""rv"".
1282| }
1283|
1284|-> return rv;
1285| }
1286|
(cherry picked from commit b90bd3e5bbc136f53b24ee791824acd6b17e0d42)
Co-authored-by: Victor Stinner <vstinner@python.org>
Diffstat (limited to 'Modules')
| -rw-r--r-- | Modules/_zoneinfo.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/Modules/_zoneinfo.c b/Modules/_zoneinfo.c index 38c3f0c..902ece7 100644 --- a/Modules/_zoneinfo.c +++ b/Modules/_zoneinfo.c @@ -944,6 +944,7 @@ end: static int load_data(zoneinfo_state *state, PyZoneInfo_ZoneInfo *self, PyObject *file_obj) { + int rv = 0; PyObject *data_tuple = NULL; long *utcoff = NULL; @@ -1220,7 +1221,6 @@ load_data(zoneinfo_state *state, PyZoneInfo_ZoneInfo *self, PyObject *file_obj) } } - int rv = 0; goto cleanup; error: // These resources only need to be freed if we have failed, if we succeed |