summaryrefslogtreecommitdiffstats
path: root/Modules
diff options
context:
space:
mode:
authorGregory P. Smith <greg@mad-scientist.com>2010-12-14 13:43:30 (GMT)
committerGregory P. Smith <greg@mad-scientist.com>2010-12-14 13:43:30 (GMT)
commit8edd99d0852c45f70b6abc851e6b326d4250cd33 (patch)
tree739c5f3039791b749228455076e6af2d89d71b8c /Modules
parent39f34aa1f3c1f02d72ec28d0d177834e22dfc89b (diff)
downloadcpython-8edd99d0852c45f70b6abc851e6b326d4250cd33.zip
cpython-8edd99d0852c45f70b6abc851e6b326d4250cd33.tar.gz
cpython-8edd99d0852c45f70b6abc851e6b326d4250cd33.tar.bz2
Issue #6559: fix the subprocess.Popen pass_fds implementation. Add a unittest.
Issue #7213: Change the close_fds default on Windows to better match the new default on POSIX. True when possible (False if stdin/stdout/stderr are supplied). Update the documentation to reflect all of the above.
Diffstat (limited to 'Modules')
-rw-r--r--Modules/_posixsubprocess.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/Modules/_posixsubprocess.c b/Modules/_posixsubprocess.c
index 0b5e544..5f226a8 100644
--- a/Modules/_posixsubprocess.c
+++ b/Modules/_posixsubprocess.c
@@ -107,7 +107,7 @@ static void child_exec(char *const exec_array[],
errno = 0; /* We don't want to report an OSError. */
goto error;
}
- if (keep_fd <= start_fd)
+ if (keep_fd < start_fd)
continue;
for (fd_num = start_fd; fd_num < keep_fd; ++fd_num) {
close(fd_num);