summaryrefslogtreecommitdiffstats
path: root/Modules
diff options
context:
space:
mode:
authorMiss Islington (bot) <31488909+miss-islington@users.noreply.github.com>2017-09-10 16:46:49 (GMT)
committerStefan Krah <skrah@bytereef.org>2017-09-10 16:46:49 (GMT)
commitf8909d0e4b652256e4da153fa6be664490f60a07 (patch)
tree3ab7a9a390556fb1ee4254df14281a064fde3f12 /Modules
parent638601ec52858e19a4e3498c1057a62ee1481e65 (diff)
downloadcpython-f8909d0e4b652256e4da153fa6be664490f60a07.zip
cpython-f8909d0e4b652256e4da153fa6be664490f60a07.tar.gz
cpython-f8909d0e4b652256e4da153fa6be664490f60a07.tar.bz2
[3.6] bpo-31406: Fix crash due to lack of type checking in subclassing. (GH-3477) (#3479)
(cherry picked from commit 3cedf46cdbeefc019f4a672c1104f3d5e94712bd)
Diffstat (limited to 'Modules')
-rw-r--r--Modules/_decimal/_decimal.c19
1 files changed, 14 insertions, 5 deletions
diff --git a/Modules/_decimal/_decimal.c b/Modules/_decimal/_decimal.c
index fcc1f15..13418c9 100644
--- a/Modules/_decimal/_decimal.c
+++ b/Modules/_decimal/_decimal.c
@@ -2163,13 +2163,17 @@ dec_from_long(PyTypeObject *type, const PyObject *v,
/* Return a new PyDecObject from a PyLongObject. Use the context for
conversion. */
static PyObject *
-PyDecType_FromLong(PyTypeObject *type, const PyObject *pylong,
- PyObject *context)
+PyDecType_FromLong(PyTypeObject *type, const PyObject *v, PyObject *context)
{
PyObject *dec;
uint32_t status = 0;
- dec = dec_from_long(type, pylong, CTX(context), &status);
+ if (!PyLong_Check(v)) {
+ PyErr_SetString(PyExc_TypeError, "argument must be an integer");
+ return NULL;
+ }
+
+ dec = dec_from_long(type, v, CTX(context), &status);
if (dec == NULL) {
return NULL;
}
@@ -2185,15 +2189,20 @@ PyDecType_FromLong(PyTypeObject *type, const PyObject *pylong,
/* Return a new PyDecObject from a PyLongObject. Use a maximum context
for conversion. If the conversion is not exact, set InvalidOperation. */
static PyObject *
-PyDecType_FromLongExact(PyTypeObject *type, const PyObject *pylong,
+PyDecType_FromLongExact(PyTypeObject *type, const PyObject *v,
PyObject *context)
{
PyObject *dec;
uint32_t status = 0;
mpd_context_t maxctx;
+ if (!PyLong_Check(v)) {
+ PyErr_SetString(PyExc_TypeError, "argument must be an integer");
+ return NULL;
+ }
+
mpd_maxcontext(&maxctx);
- dec = dec_from_long(type, pylong, &maxctx, &status);
+ dec = dec_from_long(type, v, &maxctx, &status);
if (dec == NULL) {
return NULL;
}