diff options
author | Gregory P. Smith <greg@krypto.org> | 2013-12-01 03:02:57 (GMT) |
---|---|---|
committer | Gregory P. Smith <greg@krypto.org> | 2013-12-01 03:02:57 (GMT) |
commit | 1eda9e7c3074bfe37674c8140b3d02bf94caf4f3 (patch) | |
tree | 66e0ccc1c1d085cfdfb6335f07b48e57dac0d4e2 /Modules | |
parent | 65846c6c5190a92446176f318fd837c6005cfa29 (diff) | |
download | cpython-1eda9e7c3074bfe37674c8140b3d02bf94caf4f3.zip cpython-1eda9e7c3074bfe37674c8140b3d02bf94caf4f3.tar.gz cpython-1eda9e7c3074bfe37674c8140b3d02bf94caf4f3.tar.bz2 |
Fixes Issue #15798 - subprocess.Popen() no longer fails if file
descriptor 0, 1 or 2 is closed.
Diffstat (limited to 'Modules')
-rw-r--r-- | Modules/_posixsubprocess.c | 6 |
1 files changed, 1 insertions, 5 deletions
diff --git a/Modules/_posixsubprocess.c b/Modules/_posixsubprocess.c index 8d65530..fa1975c 100644 --- a/Modules/_posixsubprocess.c +++ b/Modules/_posixsubprocess.c @@ -449,7 +449,7 @@ child_exec(char *const exec_array[], local_max_fd = max_fd; #endif /* TODO HP-UX could use pstat_getproc() if anyone cares about it. */ - _close_open_fd_range(3, local_max_fd, py_fds_to_keep); + _close_open_fd_range(0, local_max_fd, py_fds_to_keep); } /* This loop matches the Lib/os.py _execvpe()'s PATH search when */ @@ -526,10 +526,6 @@ subprocess_fork_exec(PyObject* self, PyObject *args) &restore_signals, &call_setsid, &preexec_fn)) return NULL; - if (close_fds && errpipe_write < 3) { /* precondition */ - PyErr_SetString(PyExc_ValueError, "errpipe_write must be >= 3"); - return NULL; - } if (PySequence_Length(py_fds_to_keep) < 0) { PyErr_SetString(PyExc_ValueError, "cannot get length of fds_to_keep"); return NULL; |