diff options
author | Martin Panter <vadmium+py@gmail.com> | 2015-11-07 03:15:32 (GMT) |
---|---|---|
committer | Martin Panter <vadmium+py@gmail.com> | 2015-11-07 03:15:32 (GMT) |
commit | 9513ba3b8f0e30f88ce8e04b6da920d9237fb4ee (patch) | |
tree | c683d7c4ddfbf1052ac481f894fd9bdd0542e412 /Objects/abstract.c | |
parent | eb1d89abddcb365180af819fddcbaad1fae31ba2 (diff) | |
parent | 61d6e4ae9db80e3f87104a03499ff89d3c275b22 (diff) | |
download | cpython-9513ba3b8f0e30f88ce8e04b6da920d9237fb4ee.zip cpython-9513ba3b8f0e30f88ce8e04b6da920d9237fb4ee.tar.gz cpython-9513ba3b8f0e30f88ce8e04b6da920d9237fb4ee.tar.bz2 |
Issue #24802: Merge null termination fixes from 3.5
Diffstat (limited to 'Objects/abstract.c')
-rw-r--r-- | Objects/abstract.c | 22 |
1 files changed, 20 insertions, 2 deletions
diff --git a/Objects/abstract.c b/Objects/abstract.c index 2c1c76e..3e1ff97 100644 --- a/Objects/abstract.c +++ b/Objects/abstract.c @@ -1312,12 +1312,30 @@ PyNumber_Long(PyObject *o) /* The below check is done in PyLong_FromUnicode(). */ return PyLong_FromUnicodeObject(o, 10); - if (PyObject_GetBuffer(o, &view, PyBUF_SIMPLE) == 0) { + if (PyBytes_Check(o)) /* need to do extra error checking that PyLong_FromString() * doesn't do. In particular int('9\x005') must raise an * exception, not truncate at the null. */ - PyObject *result = _PyLong_FromBytes(view.buf, view.len, 10); + return _PyLong_FromBytes(PyBytes_AS_STRING(o), + PyBytes_GET_SIZE(o), 10); + + if (PyByteArray_Check(o)) + return _PyLong_FromBytes(PyByteArray_AS_STRING(o), + PyByteArray_GET_SIZE(o), 10); + + if (PyObject_GetBuffer(o, &view, PyBUF_SIMPLE) == 0) { + PyObject *result, *bytes; + + /* Copy to NUL-terminated buffer. */ + bytes = PyBytes_FromStringAndSize((const char *)view.buf, view.len); + if (bytes == NULL) { + PyBuffer_Release(&view); + return NULL; + } + result = _PyLong_FromBytes(PyBytes_AS_STRING(bytes), + PyBytes_GET_SIZE(bytes), 10); + Py_DECREF(bytes); PyBuffer_Release(&view); return result; } |