summaryrefslogtreecommitdiffstats
path: root/Objects/bytesobject.c
diff options
context:
space:
mode:
authorGregory P. Smith <greg@krypto.org>2012-12-11 02:15:46 (GMT)
committerGregory P. Smith <greg@krypto.org>2012-12-11 02:15:46 (GMT)
commit27cbcd6241d787b5e99c6ed05ec8377051f397aa (patch)
tree02fe4460f5a52993a36a9aa575397f9001700ae1 /Objects/bytesobject.c
parent90555d0f0d0b8e4ffbbb37ba12a8e43020ad1e98 (diff)
downloadcpython-27cbcd6241d787b5e99c6ed05ec8377051f397aa.zip
cpython-27cbcd6241d787b5e99c6ed05ec8377051f397aa.tar.gz
cpython-27cbcd6241d787b5e99c6ed05ec8377051f397aa.tar.bz2
Fix the internals of our hash functions to used unsigned values during hash
computation as the overflow behavior of signed integers is undefined. In practice we require compiling everything with -fwrapv which forces overflow to be defined as twos compliment but this keeps the code cleaner for checkers or in the case where someone has compiled it without -fwrapv or their compiler's equivalent. Found by Clang trunk's Undefined Behavior Sanitizer (UBSan). Cleanup only - no functionality or hash values change.
Diffstat (limited to 'Objects/bytesobject.c')
-rw-r--r--Objects/bytesobject.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/Objects/bytesobject.c b/Objects/bytesobject.c
index 796e400..ef3a5a1 100644
--- a/Objects/bytesobject.c
+++ b/Objects/bytesobject.c
@@ -873,7 +873,7 @@ bytes_hash(PyBytesObject *a)
{
register Py_ssize_t len;
register unsigned char *p;
- register Py_hash_t x;
+ register Py_uhash_t x; /* Unsigned for defined overflow behavior. */
#ifdef Py_DEBUG
assert(_Py_HashSecret_Initialized);