summaryrefslogtreecommitdiffstats
path: root/Objects/dictobject.c
diff options
context:
space:
mode:
authorZackery Spytz <zspytz@gmail.com>2019-03-24 02:23:29 (GMT)
committerInada Naoki <songofacandy@gmail.com>2019-03-24 02:23:29 (GMT)
commit3d07c1ee1d2d475b74816117981d6ec752c26c23 (patch)
treeff27179fff70f36717b3da0cade794ca81f6cf54 /Objects/dictobject.c
parenta7987e71939fa631296f83861fb376361ddd59ee (diff)
downloadcpython-3d07c1ee1d2d475b74816117981d6ec752c26c23.zip
cpython-3d07c1ee1d2d475b74816117981d6ec752c26c23.tar.gz
cpython-3d07c1ee1d2d475b74816117981d6ec752c26c23.tar.bz2
bpo-36412: fix a possible crash in dictobject.c's new_dict() (GH-12519)
Diffstat (limited to 'Objects/dictobject.c')
-rw-r--r--Objects/dictobject.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/Objects/dictobject.c b/Objects/dictobject.c
index 524ff67..e2603e1 100644
--- a/Objects/dictobject.c
+++ b/Objects/dictobject.c
@@ -604,7 +604,9 @@ new_dict(PyDictKeysObject *keys, PyObject **values)
mp = PyObject_GC_New(PyDictObject, &PyDict_Type);
if (mp == NULL) {
dictkeys_decref(keys);
- free_values(values);
+ if (values != empty_values) {
+ free_values(values);
+ }
return NULL;
}
}