diff options
| author | Victor Stinner <vstinner@python.org> | 2022-11-22 12:39:11 (GMT) |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-11-22 12:39:11 (GMT) |
| commit | 135ec7cefbaffd516b77362ad2b2ad1025af462e (patch) | |
| tree | 1f92fbda32d21f0efc9f54432c32af03fe49a608 /Objects/genobject.c | |
| parent | 3db0a21f731cec28a89f7495a82ee2670bce75fe (diff) | |
| download | cpython-135ec7cefbaffd516b77362ad2b2ad1025af462e.zip cpython-135ec7cefbaffd516b77362ad2b2ad1025af462e.tar.gz cpython-135ec7cefbaffd516b77362ad2b2ad1025af462e.tar.bz2 | |
gh-99537: Use Py_SETREF() function in C code (#99657)
Fix potential race condition in code patterns:
* Replace "Py_DECREF(var); var = new;" with "Py_SETREF(var, new);"
* Replace "Py_XDECREF(var); var = new;" with "Py_XSETREF(var, new);"
* Replace "Py_CLEAR(var); var = new;" with "Py_XSETREF(var, new);"
Other changes:
* Replace "old = var; var = new; Py_DECREF(var)"
with "Py_SETREF(var, new);"
* Replace "old = var; var = new; Py_XDECREF(var)"
with "Py_XSETREF(var, new);"
* And remove the "old" variable.
Diffstat (limited to 'Objects/genobject.c')
| -rw-r--r-- | Objects/genobject.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/Objects/genobject.c b/Objects/genobject.c index 6661e3f..c006f1a 100644 --- a/Objects/genobject.c +++ b/Objects/genobject.c @@ -491,8 +491,7 @@ throw_here: } else { /* Normalize to raise <class>, <instance> */ - Py_XDECREF(val); - val = typ; + Py_XSETREF(val, typ); typ = Py_NewRef(PyExceptionInstance_Class(typ)); if (tb == NULL) |