diff options
author | Fred Drake <fdrake@acm.org> | 2000-06-30 15:01:00 (GMT) |
---|---|---|
committer | Fred Drake <fdrake@acm.org> | 2000-06-30 15:01:00 (GMT) |
commit | a44d353e2b6d947d36ab9d36c1fc84335a0878fe (patch) | |
tree | 3d0add21fcb365aeeb5ac6b45add0a30e6f3b93b /Objects/methodobject.c | |
parent | d49e5b466731d0e68ea41655aecbe3a66b1976d9 (diff) | |
download | cpython-a44d353e2b6d947d36ab9d36c1fc84335a0878fe.zip cpython-a44d353e2b6d947d36ab9d36c1fc84335a0878fe.tar.gz cpython-a44d353e2b6d947d36ab9d36c1fc84335a0878fe.tar.bz2 |
Trent Mick <trentm@activestate.com>:
The common technique for printing out a pointer has been to cast to a long
and use the "%lx" printf modifier. This is incorrect on Win64 where casting
to a long truncates the pointer. The "%p" formatter should be used instead.
The problem as stated by Tim:
> Unfortunately, the C committee refused to define what %p conversion "looks
> like" -- they explicitly allowed it to be implementation-defined. Older
> versions of Microsoft C even stuck a colon in the middle of the address (in
> the days of segment+offset addressing)!
The result is that the hex value of a pointer will maybe/maybe not have a 0x
prepended to it.
Notes on the patch:
There are two main classes of changes:
- in the various repr() functions that print out pointers
- debugging printf's in the various thread_*.h files (these are why the
patch is large)
Closes SourceForge patch #100505.
Diffstat (limited to 'Objects/methodobject.c')
-rw-r--r-- | Objects/methodobject.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/Objects/methodobject.c b/Objects/methodobject.c index 580bb2f..ec98de4 100644 --- a/Objects/methodobject.c +++ b/Objects/methodobject.c @@ -148,9 +148,9 @@ meth_repr(m) sprintf(buf, "<built-in function %.80s>", m->m_ml->ml_name); else sprintf(buf, - "<built-in method %.80s of %.80s object at %lx>", + "<built-in method %.80s of %.80s object at %p>", m->m_ml->ml_name, m->m_self->ob_type->tp_name, - (long)m->m_self); + m->m_self); return PyString_FromString(buf); } |