diff options
author | Kristján Valur Jónsson <sweskman@gmail.com> | 2014-03-05 13:47:57 (GMT) |
---|---|---|
committer | Kristján Valur Jónsson <sweskman@gmail.com> | 2014-03-05 13:47:57 (GMT) |
commit | 25dded041fe532fcb041b6e68582bf76b4968132 (patch) | |
tree | 3c70fceb3fe5ef98a17b85aa94704d20eb5a853d /Objects/rangeobject.c | |
parent | 4ca688edeb07de955e1ef67c11f0e327f12ffa6e (diff) | |
download | cpython-25dded041fe532fcb041b6e68582bf76b4968132.zip cpython-25dded041fe532fcb041b6e68582bf76b4968132.tar.gz cpython-25dded041fe532fcb041b6e68582bf76b4968132.tar.bz2 |
Make the various iterators' "setstate" sliently and consistently clip the
index. This avoids the possibility of setting an iterator to an invalid
state.
Diffstat (limited to 'Objects/rangeobject.c')
-rw-r--r-- | Objects/rangeobject.c | 31 |
1 files changed, 27 insertions, 4 deletions
diff --git a/Objects/rangeobject.c b/Objects/rangeobject.c index 4b218b8..f2030c3 100644 --- a/Objects/rangeobject.c +++ b/Objects/rangeobject.c @@ -1000,10 +1000,11 @@ rangeiter_setstate(rangeiterobject *r, PyObject *state) long index = PyLong_AsLong(state); if (index == -1 && PyErr_Occurred()) return NULL; - if (index < 0 || index > r->len) { - PyErr_SetString(PyExc_ValueError, "index out of range"); - return NULL; - } + /* silently clip the index value */ + if (index < 0) + index = 0; + else if (index > r->len) + index = r->len; /* exhausted iterator */ r->index = index; Py_RETURN_NONE; } @@ -1178,6 +1179,28 @@ longrangeiter_reduce(longrangeiterobject *r) static PyObject * longrangeiter_setstate(longrangeiterobject *r, PyObject *state) { + int cmp; + + /* clip the value */ + PyObject *zero = PyLong_FromLong(0); + if (zero == NULL) + return NULL; + cmp = PyObject_RichCompareBool(state, zero, Py_LT); + if (cmp > 0) { + Py_CLEAR(r->index); + r->index = zero; + Py_RETURN_NONE; + } + Py_DECREF(zero); + if (cmp < 0) + return NULL; + + cmp = PyObject_RichCompareBool(r->len, state, Py_LT); + if (cmp < 0) + return NULL; + if (cmp > 0) + state = r->len; + Py_CLEAR(r->index); r->index = state; Py_INCREF(r->index); |