diff options
| author | Serhiy Storchaka <storchaka@gmail.com> | 2016-12-14 17:56:53 (GMT) |
|---|---|---|
| committer | Serhiy Storchaka <storchaka@gmail.com> | 2016-12-14 17:56:53 (GMT) |
| commit | bdfc5ff17e9ad6c924aeb5f62ba51e948deec589 (patch) | |
| tree | c5aad7d8f387b19c1fc55997c61c9bdd2182965c /Objects | |
| parent | 69598527c7b8c538d75ec1b69c54f317dee0c47a (diff) | |
| parent | 386072ebe02b54eb9fb303031c769bef094967f5 (diff) | |
| download | cpython-bdfc5ff17e9ad6c924aeb5f62ba51e948deec589.zip cpython-bdfc5ff17e9ad6c924aeb5f62ba51e948deec589.tar.gz cpython-bdfc5ff17e9ad6c924aeb5f62ba51e948deec589.tar.bz2 | |
Merge from 3.6.
Diffstat (limited to 'Objects')
| -rw-r--r-- | Objects/typeobject.c | 29 |
1 files changed, 1 insertions, 28 deletions
diff --git a/Objects/typeobject.c b/Objects/typeobject.c index 88493b5..391eed3 100644 --- a/Objects/typeobject.c +++ b/Objects/typeobject.c @@ -6847,34 +6847,7 @@ update_one_slot(PyTypeObject *type, slotdef *p) sanity checks and constructing a new argument list. Cut all that nonsense short -- this speeds up instance creation tremendously. */ - PyObject *self = PyCFunction_GET_SELF(descr); - if (!self || !PyType_Check(self)) { - /* This should never happen because - tp_new_wrapper expects a type for self. - Use slot_tp_new which will call - tp_new_wrapper which will raise an - exception. */ - specific = (void *)slot_tp_new; - } - else { - PyTypeObject *staticbase; - specific = ((PyTypeObject *)self)->tp_new; - /* Check that the user does not do anything - silly and unsafe like object.__new__(dict). - To do this, we check that the most derived - base that's not a heap type is this type. */ - staticbase = type->tp_base; - while (staticbase && - (staticbase->tp_flags & Py_TPFLAGS_HEAPTYPE)) - staticbase = staticbase->tp_base; - if (staticbase && - staticbase->tp_new != specific) - /* Seems to be unsafe, better use - slot_tp_new which will call - tp_new_wrapper which will raise an - exception if it is unsafe. */ - specific = (void *)slot_tp_new; - } + specific = (void *)type->tp_new; /* XXX I'm not 100% sure that there isn't a hole in this reasoning that requires additional sanity checks. I'll buy the first person to |
