summaryrefslogtreecommitdiffstats
path: root/Objects
diff options
context:
space:
mode:
authorAntoine Pitrou <solipsis@pitrou.net>2010-07-11 12:14:05 (GMT)
committerAntoine Pitrou <solipsis@pitrou.net>2010-07-11 12:14:05 (GMT)
commit3266978300ace81216e7cf7d072d43319efa2f65 (patch)
tree24bda4037bdee85ec36a95c6b308736910798209 /Objects
parentfbf2f14777d4d4d6bd6ea635e3413201964606f5 (diff)
downloadcpython-3266978300ace81216e7cf7d072d43319efa2f65.zip
cpython-3266978300ace81216e7cf7d072d43319efa2f65.tar.gz
cpython-3266978300ace81216e7cf7d072d43319efa2f65.tar.bz2
Merged revisions 82814 via svnmerge from
svn+ssh://pythondev@svn.python.org/python/branches/py3k ........ r82814 | antoine.pitrou | 2010-07-11 14:12:00 +0200 (dim., 11 juil. 2010) | 4 lines Issue #7616: Fix copying of overlapping memoryview slices with the Intel compiler. ........
Diffstat (limited to 'Objects')
-rw-r--r--Objects/memoryobject.c14
1 files changed, 3 insertions, 11 deletions
diff --git a/Objects/memoryobject.c b/Objects/memoryobject.c
index 524521a..8c21ac1 100644
--- a/Objects/memoryobject.c
+++ b/Objects/memoryobject.c
@@ -632,7 +632,7 @@ memory_subscript(PyMemoryViewObject *self, PyObject *key)
static int
memory_ass_sub(PyMemoryViewObject *self, PyObject *key, PyObject *value)
{
- Py_ssize_t start, len, bytelen, i;
+ Py_ssize_t start, len, bytelen;
Py_buffer srcview;
Py_buffer *view = &(self->view);
char *srcbuf, *destbuf;
@@ -702,16 +702,8 @@ memory_ass_sub(PyMemoryViewObject *self, PyObject *key, PyObject *value)
if (destbuf + bytelen < srcbuf || srcbuf + bytelen < destbuf)
/* No overlapping */
memcpy(destbuf, srcbuf, bytelen);
- else if (destbuf < srcbuf) {
- /* Copy in ascending order */
- for (i = 0; i < bytelen; i++)
- destbuf[i] = srcbuf[i];
- }
- else {
- /* Copy in descencing order */
- for (i = bytelen - 1; i >= 0; i--)
- destbuf[i] = srcbuf[i];
- }
+ else
+ memmove(destbuf, srcbuf, bytelen);
PyBuffer_Release(&srcview);
return 0;