diff options
| author | Neal Norwitz <nnorwitz@gmail.com> | 2006-07-17 00:57:15 (GMT) |
|---|---|---|
| committer | Neal Norwitz <nnorwitz@gmail.com> | 2006-07-17 00:57:15 (GMT) |
| commit | 04e39ec81592915803bc253a6567153d18a2e71a (patch) | |
| tree | 3fdbc3f7cbfcab5c6403814fb7abf6a220fbb4f1 /Objects | |
| parent | b337bb541bc3986f50d352fe13508ac8f0667bb0 (diff) | |
| download | cpython-04e39ec81592915803bc253a6567153d18a2e71a.zip cpython-04e39ec81592915803bc253a6567153d18a2e71a.tar.gz cpython-04e39ec81592915803bc253a6567153d18a2e71a.tar.bz2 | |
otherset is known to be non-NULL based on checks before and DECREF after.
DECREF otherset rather than XDECREF in error conditions too.
Reported by Klockwork #154.
Diffstat (limited to 'Objects')
| -rw-r--r-- | Objects/setobject.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/Objects/setobject.c b/Objects/setobject.c index f10fdd7..3ddb675 100644 --- a/Objects/setobject.c +++ b/Objects/setobject.c @@ -1380,12 +1380,12 @@ set_symmetric_difference_update(PySetObject *so, PyObject *other) while (set_next(otherset, &pos, &entry)) { int rv = set_discard_entry(so, entry); if (rv == -1) { - Py_XDECREF(otherset); + Py_DECREF(otherset); return NULL; } if (rv == DISCARD_NOTFOUND) { if (set_add_entry(so, entry) == -1) { - Py_XDECREF(otherset); + Py_DECREF(otherset); return NULL; } } |