diff options
author | Barry Warsaw <barry@python.org> | 2001-11-28 21:00:41 (GMT) |
---|---|---|
committer | Barry Warsaw <barry@python.org> | 2001-11-28 21:00:41 (GMT) |
commit | e5c492d72af26a1478e4aa9f3dbdadf1068ee618 (patch) | |
tree | b57d2f8750a1a2645ef5d6778ab0191695ae34a6 /Objects | |
parent | 312af42b47ad32ad8935b5706a890865a4f34d40 (diff) | |
download | cpython-e5c492d72af26a1478e4aa9f3dbdadf1068ee618.zip cpython-e5c492d72af26a1478e4aa9f3dbdadf1068ee618.tar.gz cpython-e5c492d72af26a1478e4aa9f3dbdadf1068ee618.tar.bz2 |
formatfloat(), formatint(): Conversion of sprintf() to PyOS_snprintf()
for buffer overrun avoidance.
Diffstat (limited to 'Objects')
-rw-r--r-- | Objects/unicodeobject.c | 10 |
1 files changed, 6 insertions, 4 deletions
diff --git a/Objects/unicodeobject.c b/Objects/unicodeobject.c index f793020..c456b57 100644 --- a/Objects/unicodeobject.c +++ b/Objects/unicodeobject.c @@ -5080,7 +5080,8 @@ formatfloat(Py_UNICODE *buf, prec = 6; if (type == 'f' && (fabs(x) / 1e25) >= 1e25) type = 'g'; - sprintf(fmt, "%%%s.%d%c", (flags & F_ALT) ? "#" : "", prec, type); + PyOS_snprintf(fmt, sizeof(fmt), "%%%s.%d%c", + (flags & F_ALT) ? "#" : "", prec, type); /* worst case length calc to ensure no buffer overrun: fmt = %#.<prec>g buf = '-' + [0-9]*prec + '.' + 'e+' + (longest exp @@ -5151,15 +5152,16 @@ formatint(Py_UNICODE *buf, */ if (x == 0 && (flags & F_ALT) && (type == 'x' || type == 'X')) { /* Only way to know what the platform does is to try it. */ - sprintf(fmt, type == 'x' ? "%#x" : "%#X", 0); + PyOS_snprintf(fmt, sizeof(fmt), type == 'x' ? "%#x" : "%#X", 0); if (fmt[1] != (char)type) { /* Supply our own leading 0x/0X -- needed under std C */ use_native_c_format = 0; - sprintf(fmt, "0%c%%#.%dl%c", type, prec, type); + PyOS_snprintf(fmt, sizeof(fmt), "0%c%%#.%dl%c", type, prec, type); } } if (use_native_c_format) - sprintf(fmt, "%%%s.%dl%c", (flags & F_ALT) ? "#" : "", prec, type); + PyOS_snprintf(fmt, sizeof(fmt), "%%%s.%dl%c", + (flags & F_ALT) ? "#" : "", prec, type); return usprintf(buf, fmt, x); } |