summaryrefslogtreecommitdiffstats
path: root/Objects
diff options
context:
space:
mode:
authorMark Dickinson <dickinsm@gmail.com>2013-04-13 14:26:58 (GMT)
committerMark Dickinson <dickinsm@gmail.com>2013-04-13 14:26:58 (GMT)
commit64aafeb4de3b5e85007f2107250e6f1da4df2516 (patch)
tree39057074fa67114998a802a6e2761e37734ce021 /Objects
parenteff64447512b026416fce4e65730e25633a5f1ac (diff)
downloadcpython-64aafeb4de3b5e85007f2107250e6f1da4df2516.zip
cpython-64aafeb4de3b5e85007f2107250e6f1da4df2516.tar.gz
cpython-64aafeb4de3b5e85007f2107250e6f1da4df2516.tar.bz2
Issue #16447: Fix potential segfault when setting __name__ on a class.
Diffstat (limited to 'Objects')
-rw-r--r--Objects/typeobject.c5
1 files changed, 4 insertions, 1 deletions
diff --git a/Objects/typeobject.c b/Objects/typeobject.c
index 9f89972..6ece741 100644
--- a/Objects/typeobject.c
+++ b/Objects/typeobject.c
@@ -298,10 +298,13 @@ type_set_name(PyTypeObject *type, PyObject *value, void *context)
Py_INCREF(value);
- Py_DECREF(et->ht_name);
+ /* Wait until et is a sane state before Py_DECREF'ing the old et->ht_name
+ value. (Bug #16447.) */
+ tmp = et->ht_name;
et->ht_name = value;
type->tp_name = tp_name;
+ Py_DECREF(tmp);
return 0;
}