summaryrefslogtreecommitdiffstats
path: root/Objects
diff options
context:
space:
mode:
authorBenjamin Peterson <benjamin@python.org>2015-06-07 04:20:32 (GMT)
committerBenjamin Peterson <benjamin@python.org>2015-06-07 04:20:32 (GMT)
commit99e96f2bb0c4653b3bb90f21f42d81e0b17d8ed1 (patch)
tree6239ec921e3f73059c2a5b1c065517dd02c08f7e /Objects
parent277b9752609a32d99d968e653d34f92cb03e476c (diff)
downloadcpython-99e96f2bb0c4653b3bb90f21f42d81e0b17d8ed1.zip
cpython-99e96f2bb0c4653b3bb90f21f42d81e0b17d8ed1.tar.gz
cpython-99e96f2bb0c4653b3bb90f21f42d81e0b17d8ed1.tar.bz2
remove unnecessary braces and indentation
Diffstat (limited to 'Objects')
-rw-r--r--Objects/odictobject.c115
1 files changed, 57 insertions, 58 deletions
diff --git a/Objects/odictobject.c b/Objects/odictobject.c
index 13ffdf1..a490e78 100644
--- a/Objects/odictobject.c
+++ b/Objects/odictobject.c
@@ -2404,81 +2404,80 @@ mutablemapping_update(PyObject *self, PyObject *args, PyObject *kwargs)
/* first handle args, if any */
if (len < 0) /* PyObject_Size raised an exception. */
return NULL;
- else if (len > 1) {
+
+ if (len > 1) {
char *msg = "update() takes at most 1 positional argument (%d given)";
PyErr_Format(PyExc_TypeError, msg, len);
return NULL;
}
- else if (len == 1) {
- PyObject *other = PyTuple_GET_ITEM(args, 0); /* borrowed reference */
- if (other == NULL)
+
+
+ PyObject *other = PyTuple_GET_ITEM(args, 0); /* borrowed reference */
+ if (other == NULL)
+ return NULL;
+ Py_INCREF(other);
+ if (PyObject_HasAttrString(other, "items")) { /* never fails */
+ PyObject *items = PyMapping_Items(other);
+ Py_DECREF(other);
+ if (items == NULL)
return NULL;
- Py_INCREF(other);
- if (PyObject_HasAttrString(other, "items")) { /* never fails */
- PyObject *items = PyMapping_Items(other);
+ res = mutablemapping_add_pairs(self, items);
+ Py_DECREF(items);
+ if (res == -1)
+ return NULL;
+ }
+ else if (PyObject_HasAttrString(other, "keys")) { /* never fails */
+ PyObject *keys, *iterator, *key;
+ keys = PyObject_CallMethod(other, "keys", NULL);
+ if (keys == NULL) {
Py_DECREF(other);
- if (items == NULL)
- return NULL;
- res = mutablemapping_add_pairs(self, items);
- Py_DECREF(items);
- if (res == -1)
- return NULL;
+ return NULL;
}
- else if (PyObject_HasAttrString(other, "keys")) { /* never fails */
- PyObject *keys, *iterator, *key;
- keys = PyObject_CallMethod(other, "keys", NULL);
- if (keys == NULL) {
- Py_DECREF(other);
- return NULL;
- }
- iterator = PyObject_GetIter(keys);
- Py_DECREF(keys);
- if (iterator == NULL) {
- Py_DECREF(other);
- return NULL;
- }
- while (res == 0 && (key = PyIter_Next(iterator))) {
- PyObject *value = PyObject_GetItem(other, key);
- if (value != NULL) {
- res = PyObject_SetItem(self, key, value);
- Py_DECREF(value);
- }
- else {
- res = -1;
- }
- Py_DECREF(key);
- }
+ iterator = PyObject_GetIter(keys);
+ Py_DECREF(keys);
+ if (iterator == NULL) {
Py_DECREF(other);
- Py_DECREF(iterator);
- if (res != 0 || PyErr_Occurred())
- return NULL;
+ return NULL;
}
- else {
- res = mutablemapping_add_pairs(self, other);
- Py_DECREF(other);
- if (res != 0)
- return NULL;
+ while (res == 0 && (key = PyIter_Next(iterator))) {
+ PyObject *value = PyObject_GetItem(other, key);
+ if (value != NULL) {
+ res = PyObject_SetItem(self, key, value);
+ Py_DECREF(value);
+ }
+ else {
+ res = -1;
+ }
+ Py_DECREF(key);
}
+ Py_DECREF(other);
+ Py_DECREF(iterator);
+ if (res != 0 || PyErr_Occurred())
+ return NULL;
+ }
+ else {
+ res = mutablemapping_add_pairs(self, other);
+ Py_DECREF(other);
+ if (res != 0)
+ return NULL;
}
/* now handle kwargs */
len = (kwargs != NULL) ? PyObject_Size(kwargs) : 0;
if (len < 0) /* PyObject_Size raised an exception. */
return NULL;
- else if (len > 0) {
- PyObject *items;
- if (!PyMapping_Check(kwargs)) {
- PyErr_SetString(PyExc_TypeError, "expected mapping for kwargs");
- return NULL;
- }
- items = PyMapping_Items(kwargs);
- if (items == NULL)
- return NULL;
- res = mutablemapping_add_pairs(self, items);
- Py_DECREF(items);
- if (res == -1)
- return NULL;
+ PyObject *items;
+ if (!PyMapping_Check(kwargs)) {
+ PyErr_SetString(PyExc_TypeError, "expected mapping for kwargs");
+ return NULL;
}
+ items = PyMapping_Items(kwargs);
+ if (items == NULL)
+ return NULL;
+ res = mutablemapping_add_pairs(self, items);
+ Py_DECREF(items);
+ if (res == -1)
+ return NULL;
Py_RETURN_NONE;
}