summaryrefslogtreecommitdiffstats
path: root/Objects
diff options
context:
space:
mode:
authorSerhiy Storchaka <storchaka@gmail.com>2016-12-14 17:52:17 (GMT)
committerSerhiy Storchaka <storchaka@gmail.com>2016-12-14 17:52:17 (GMT)
commit49010ee323eca5d6f5264f046ec1954d818fd5a7 (patch)
tree73175f19c6e818d99eed2113a2eef96482d7dbfd /Objects
parent4347881414c2923fe3d7f14b66671e57578ad103 (diff)
downloadcpython-49010ee323eca5d6f5264f046ec1954d818fd5a7.zip
cpython-49010ee323eca5d6f5264f046ec1954d818fd5a7.tar.gz
cpython-49010ee323eca5d6f5264f046ec1954d818fd5a7.tar.bz2
Revert changeset 1f31bf3f76f5 (issue5322) except tests.
Diffstat (limited to 'Objects')
-rw-r--r--Objects/typeobject.c29
1 files changed, 1 insertions, 28 deletions
diff --git a/Objects/typeobject.c b/Objects/typeobject.c
index eac89ec..7b76e5c 100644
--- a/Objects/typeobject.c
+++ b/Objects/typeobject.c
@@ -6798,34 +6798,7 @@ update_one_slot(PyTypeObject *type, slotdef *p)
sanity checks and constructing a new argument
list. Cut all that nonsense short -- this speeds
up instance creation tremendously. */
- PyObject *self = PyCFunction_GET_SELF(descr);
- if (!self || !PyType_Check(self)) {
- /* This should never happen because
- tp_new_wrapper expects a type for self.
- Use slot_tp_new which will call
- tp_new_wrapper which will raise an
- exception. */
- specific = (void *)slot_tp_new;
- }
- else {
- PyTypeObject *staticbase;
- specific = ((PyTypeObject *)self)->tp_new;
- /* Check that the user does not do anything
- silly and unsafe like object.__new__(dict).
- To do this, we check that the most derived
- base that's not a heap type is this type. */
- staticbase = type->tp_base;
- while (staticbase &&
- (staticbase->tp_flags & Py_TPFLAGS_HEAPTYPE))
- staticbase = staticbase->tp_base;
- if (staticbase &&
- staticbase->tp_new != specific)
- /* Seems to be unsafe, better use
- slot_tp_new which will call
- tp_new_wrapper which will raise an
- exception if it is unsafe. */
- specific = (void *)slot_tp_new;
- }
+ specific = (void *)type->tp_new;
/* XXX I'm not 100% sure that there isn't a hole
in this reasoning that requires additional
sanity checks. I'll buy the first person to