diff options
author | Victor Stinner <victor.stinner@gmail.com> | 2016-03-01 20:30:30 (GMT) |
---|---|---|
committer | Victor Stinner <victor.stinner@gmail.com> | 2016-03-01 20:30:30 (GMT) |
commit | 6c9aa8f2bf46e28de74ce11d85bcd448c0d0d529 (patch) | |
tree | d60ac5d1a1c8210af5403fd948a68f802b8ba35f /Objects | |
parent | bb0dbd583bdac8f1bfb9f0a45e7014b2663d5729 (diff) | |
download | cpython-6c9aa8f2bf46e28de74ce11d85bcd448c0d0d529.zip cpython-6c9aa8f2bf46e28de74ce11d85bcd448c0d0d529.tar.gz cpython-6c9aa8f2bf46e28de74ce11d85bcd448c0d0d529.tar.bz2 |
Fix str.translate()
Issue #26464: Fix str.translate() when string is ASCII and first replacements
removes character, but next replacement uses a non-ASCII character or a string
longer than 1 character. Regression introduced in Python 3.5.0.
Diffstat (limited to 'Objects')
-rw-r--r-- | Objects/unicodeobject.c | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/Objects/unicodeobject.c b/Objects/unicodeobject.c index d4c9aae..a1ee776 100644 --- a/Objects/unicodeobject.c +++ b/Objects/unicodeobject.c @@ -8574,7 +8574,8 @@ unicode_fast_translate_lookup(PyObject *mapping, Py_UCS1 ch, translated into writer, raise an exception and return -1 on error. */ static int unicode_fast_translate(PyObject *input, PyObject *mapping, - _PyUnicodeWriter *writer, int ignore) + _PyUnicodeWriter *writer, int ignore, + Py_ssize_t *input_pos) { Py_UCS1 ascii_table[128], ch, ch2; Py_ssize_t len; @@ -8621,6 +8622,7 @@ unicode_fast_translate(PyObject *input, PyObject *mapping, exit: writer->pos = out - PyUnicode_1BYTE_DATA(writer->buffer); + *input_pos = in - PyUnicode_1BYTE_DATA(input); return res; } @@ -8666,7 +8668,7 @@ _PyUnicode_TranslateCharmap(PyObject *input, ignore = (errors != NULL && strcmp(errors, "ignore") == 0); - res = unicode_fast_translate(input, mapping, &writer, ignore); + res = unicode_fast_translate(input, mapping, &writer, ignore, &i); if (res < 0) { _PyUnicodeWriter_Dealloc(&writer); return NULL; @@ -8674,7 +8676,6 @@ _PyUnicode_TranslateCharmap(PyObject *input, if (res == 1) return _PyUnicodeWriter_Finish(&writer); - i = writer.pos; while (i<size) { /* try to encode it */ int translate; |