summaryrefslogtreecommitdiffstats
path: root/Objects
diff options
context:
space:
mode:
authorBenjamin Peterson <benjamin@python.org>2011-05-23 21:11:05 (GMT)
committerBenjamin Peterson <benjamin@python.org>2011-05-23 21:11:05 (GMT)
commit7963a35b417dfde5d97c52c05b73af738c827ca6 (patch)
tree9b2d29889b2f44a65e518fb56e8291059e0363ce /Objects
parent2cca0572848817791537efc9ee5df66d4ceb2d42 (diff)
downloadcpython-7963a35b417dfde5d97c52c05b73af738c827ca6.zip
cpython-7963a35b417dfde5d97c52c05b73af738c827ca6.tar.gz
cpython-7963a35b417dfde5d97c52c05b73af738c827ca6.tar.bz2
correctly lookup __dir__
Diffstat (limited to 'Objects')
-rw-r--r--Objects/object.c11
1 files changed, 6 insertions, 5 deletions
diff --git a/Objects/object.c b/Objects/object.c
index d534273..ac57cd7 100644
--- a/Objects/object.c
+++ b/Objects/object.c
@@ -1348,14 +1348,15 @@ error:
static PyObject *
_dir_object(PyObject *obj)
{
- PyObject * result = NULL;
- PyObject * dirfunc = PyObject_GetAttrString((PyObject*)obj->ob_type,
- "__dir__");
+ PyObject *result = NULL;
+ static PyObject *dir_str = NULL;
+ PyObject *dirfunc = _PyObject_LookupSpecial(obj, "__dir__", &dir_str);
assert(obj);
if (dirfunc == NULL) {
+ if (PyErr_Occurred())
+ return NULL;
/* use default implementation */
- PyErr_Clear();
if (PyModule_Check(obj))
result = _specialized_dir_module(obj);
else if (PyType_Check(obj))
@@ -1365,7 +1366,7 @@ _dir_object(PyObject *obj)
}
else {
/* use __dir__ */
- result = PyObject_CallFunctionObjArgs(dirfunc, obj, NULL);
+ result = PyObject_CallFunctionObjArgs(dirfunc, NULL);
Py_DECREF(dirfunc);
if (result == NULL)
return NULL;