diff options
author | Berker Peksag <berker.peksag@gmail.com> | 2017-11-24 09:53:58 (GMT) |
---|---|---|
committer | GitHub <noreply@github.com> | 2017-11-24 09:53:58 (GMT) |
commit | 4864a619dc1cc9092780ccf5a6327e8abf66133d (patch) | |
tree | 379ff96504c78c9bd6d05d6c768c3e6cf16ee3a1 /PC/_msi.c | |
parent | cdfe910e746e1d0fc43429b8cc3384a65a19b358 (diff) | |
download | cpython-4864a619dc1cc9092780ccf5a6327e8abf66133d.zip cpython-4864a619dc1cc9092780ccf5a6327e8abf66133d.tar.gz cpython-4864a619dc1cc9092780ccf5a6327e8abf66133d.tar.bz2 |
bpo-12382: Make OpenDatabase() raise better exception messages (GH-4528)
Previously, 'msilib.OpenDatabase()' function raised a
cryptical exception message when it couldn't open or
create an MSI file. For example:
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
_msi.MSIError: unknown error 6e
Diffstat (limited to 'PC/_msi.c')
-rw-r--r-- | PC/_msi.c | 6 |
1 files changed, 6 insertions, 0 deletions
@@ -315,6 +315,12 @@ msierror(int status) case ERROR_INVALID_PARAMETER: PyErr_SetString(MSIError, "invalid parameter"); return NULL; + case ERROR_OPEN_FAILED: + PyErr_SetString(MSIError, "open failed"); + return NULL; + case ERROR_CREATE_FAILED: + PyErr_SetString(MSIError, "create failed"); + return NULL; default: PyErr_Format(MSIError, "unknown error %x", status); return NULL; |