summaryrefslogtreecommitdiffstats
path: root/PC/_winreg.c
diff options
context:
space:
mode:
authorFred Drake <fdrake@acm.org>2000-06-29 19:17:04 (GMT)
committerFred Drake <fdrake@acm.org>2000-06-29 19:17:04 (GMT)
commit13634cf7a407202777285172a57cfcddb20a2047 (patch)
tree6cb9ea5a8fbe00548224ee45e04ca3bc1daff715 /PC/_winreg.c
parentb46696c0ed640992b4524aab888a26a56d993142 (diff)
downloadcpython-13634cf7a407202777285172a57cfcddb20a2047.zip
cpython-13634cf7a407202777285172a57cfcddb20a2047.tar.gz
cpython-13634cf7a407202777285172a57cfcddb20a2047.tar.bz2
This patch addresses two main issues: (1) There exist some non-fatal
errors in some of the hash algorithms. For exmaple, in float_hash and complex_hash a certain part of the value is not included in the hash calculation. See Tim's, Guido's, and my discussion of this on python-dev in May under the title "fix float_hash and complex_hash for 64-bit *nix" (2) The hash algorithms that use pointers (e.g. func_hash, code_hash) are universally not correct on Win64 (they assume that sizeof(long) == sizeof(void*)) As well, this patch significantly cleans up the hash code. It adds the two function _Py_HashDouble and _PyHash_VoidPtr that the various hashing routine are changed to use. These help maintain the hash function invariant: (a==b) => (hash(a)==hash(b))) I have added Lib/test/test_hash.py and Lib/test/output/test_hash to test this for some cases.
Diffstat (limited to 'PC/_winreg.c')
-rw-r--r--PC/_winreg.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/PC/_winreg.c b/PC/_winreg.c
index f92476e..4539959 100644
--- a/PC/_winreg.c
+++ b/PC/_winreg.c
@@ -423,7 +423,7 @@ PyHKEY_hashFunc(PyObject *ob)
/* Just use the address.
XXX - should we use the handle value?
*/
- return (long)ob;
+ return _Py_HashPointer(ob);
}