diff options
| author | Petr Viktorin <encukou@gmail.com> | 2022-07-08 15:56:26 (GMT) |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-07-08 15:56:26 (GMT) |
| commit | be862b4e55cfe3413752aba2437f9086b5315d08 (patch) | |
| tree | 739bc94ca32263de3107e99dc054663e48d93bdf /PCbuild | |
| parent | efb20a97c491821acb03564f526afaf9eed47eef (diff) | |
| download | cpython-be862b4e55cfe3413752aba2437f9086b5315d08.zip cpython-be862b4e55cfe3413752aba2437f9086b5315d08.tar.gz cpython-be862b4e55cfe3413752aba2437f9086b5315d08.tar.bz2 | |
gh-93649: Split vectorcall testing from _testcapimodule.c (GH-94549)
The `_testcapimodule.c` file is getting too large to work with effectively.
This PR lays out a general structure of how tests can be split up, with more splitting to come later if the structure is OK.
Vectorcall tests aren't the biggest issue -- it's just an area I want to work on next, so I'm starting here.
An issue specific to vectorcall tests is that it wasn't clear that e.g. `MethodDescriptor2` is related to testing vectorcall: the `/* Test PEP 590 */` section had an ambiguous end. Separate file should make things like this much clearer.
OTOH, for some pieces it might not be clear where they should be -- I left `meth_fastcall` with tests of the other calling conventions. IMO, even with the ambiguity it's still worth it to split the huge file up.
I'm not sure about the buildsystem changes, hopefully CI will tell me what's wrong.
@vstinner, @markshannon: Do you think this is a good idea?
Automerge-Triggered-By: GH:encukou
Diffstat (limited to 'PCbuild')
| -rw-r--r-- | PCbuild/_testcapi.vcxproj | 1 | ||||
| -rw-r--r-- | PCbuild/_testcapi.vcxproj.filters | 3 |
2 files changed, 4 insertions, 0 deletions
diff --git a/PCbuild/_testcapi.vcxproj b/PCbuild/_testcapi.vcxproj index c1a1943..07e2355 100644 --- a/PCbuild/_testcapi.vcxproj +++ b/PCbuild/_testcapi.vcxproj @@ -94,6 +94,7 @@ </PropertyGroup> <ItemGroup> <ClCompile Include="..\Modules\_testcapimodule.c" /> + <ClCompile Include="..\Modules\_testcapi\vectorcall.c" /> </ItemGroup> <ItemGroup> <ResourceCompile Include="..\PC\python_nt.rc" /> diff --git a/PCbuild/_testcapi.vcxproj.filters b/PCbuild/_testcapi.vcxproj.filters index 53f64b7..82fce05 100644 --- a/PCbuild/_testcapi.vcxproj.filters +++ b/PCbuild/_testcapi.vcxproj.filters @@ -12,6 +12,9 @@ <ClCompile Include="..\Modules\_testcapimodule.c"> <Filter>Source Files</Filter> </ClCompile> + <ClCompile Include="..\Modules\_testcapi\vectorcall.c"> + <Filter>Source Files</Filter> + </ClCompile> </ItemGroup> <ItemGroup> <ResourceCompile Include="..\PC\python_nt.rc"> |