diff options
| author | Gregory P. Smith <greg@krypto.org> | 2022-03-20 19:28:15 (GMT) |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-03-20 19:28:15 (GMT) |
| commit | 9d1c4d69dbc800ac344565119337fcf490cdc800 (patch) | |
| tree | f27ebdb3ae2bfa27853b42def2df6f29625ac5df /PCbuild | |
| parent | 3ae975f1ac880c47d51cca6c9e305547bd365be7 (diff) | |
| download | cpython-9d1c4d69dbc800ac344565119337fcf490cdc800.zip cpython-9d1c4d69dbc800ac344565119337fcf490cdc800.tar.gz cpython-9d1c4d69dbc800ac344565119337fcf490cdc800.tar.bz2 | |
bpo-38256: Fix binascii.crc32() when inputs are 4+GiB (GH-32000)
When compiled with `USE_ZLIB_CRC32` defined (`configure` sets this on POSIX systems), `binascii.crc32(...)` failed to compute the correct value when the input data was >= 4GiB. Because the zlib crc32 API is limited to a 32-bit length.
This lines it up with the `zlib.crc32(...)` implementation that doesn't have that flaw.
**Performance:** This also adopts the same GIL releasing for larger inputs logic that `zlib.crc32` has, and causes the Windows build to always use zlib's crc32 instead of our slow C code as zlib is a required build dependency on Windows.
Diffstat (limited to 'PCbuild')
| -rw-r--r-- | PCbuild/pythoncore.vcxproj | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/PCbuild/pythoncore.vcxproj b/PCbuild/pythoncore.vcxproj index 3686233..5e6e703 100644 --- a/PCbuild/pythoncore.vcxproj +++ b/PCbuild/pythoncore.vcxproj @@ -366,7 +366,9 @@ <ClCompile Include="..\Modules\arraymodule.c" /> <ClCompile Include="..\Modules\atexitmodule.c" /> <ClCompile Include="..\Modules\audioop.c" /> - <ClCompile Include="..\Modules\binascii.c" /> + <ClCompile Include="..\Modules\binascii.c"> + <PreprocessorDefinitions>USE_ZLIB_CRC32;%(PreprocessorDefinitions)</PreprocessorDefinitions> + </ClCompile> <ClCompile Include="..\Modules\cmathmodule.c" /> <ClCompile Include="..\Modules\_datetimemodule.c" /> <ClCompile Include="..\Modules\errnomodule.c" /> |