diff options
| author | Zachary Ware <zachary.ware@gmail.com> | 2014-08-01 04:58:27 (GMT) |
|---|---|---|
| committer | Zachary Ware <zachary.ware@gmail.com> | 2014-08-01 04:58:27 (GMT) |
| commit | c6f8c0a1de448e7ca62ece1d21f089194d31f0d9 (patch) | |
| tree | 1d4766bbb25623d5117e048ce9aee82278257447 /PCbuild | |
| parent | cb09dcacab59fd1b19346e73ee85318b18c16519 (diff) | |
| download | cpython-c6f8c0a1de448e7ca62ece1d21f089194d31f0d9.zip cpython-c6f8c0a1de448e7ca62ece1d21f089194d31f0d9.tar.gz cpython-c6f8c0a1de448e7ca62ece1d21f089194d31f0d9.tar.bz2 | |
Issue #21907: Avoid using double quotes to check argument values.
Double quotes in expanded variables can match literal double quotes,
which makes for a big mess when passing in a quoted argument (like
"/p:externalsDir=..\externals", for example).
Diffstat (limited to 'PCbuild')
| -rw-r--r-- | PCbuild/build.bat | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/PCbuild/build.bat b/PCbuild/build.bat index cde88c5..838f6ef 100644 --- a/PCbuild/build.bat +++ b/PCbuild/build.bat @@ -16,13 +16,13 @@ set target=Build set dir=%~dp0 :CheckOpts -if "%1"=="-c" (set conf=%2) & shift & shift & goto CheckOpts -if "%1"=="-p" (set platf=%2) & shift & shift & goto CheckOpts -if "%1"=="-r" (set target=Rebuild) & shift & goto CheckOpts -if "%1"=="-d" (set conf=Debug) & shift & goto CheckOpts -if "%1"=="-e" call "%dir%get_externals.bat" & shift & goto CheckOpts +if '%1'=='-c' (set conf=%2) & shift & shift & goto CheckOpts +if '%1'=='-p' (set platf=%2) & shift & shift & goto CheckOpts +if '%1'=='-r' (set target=Rebuild) & shift & goto CheckOpts +if '%1'=='-d' (set conf=Debug) & shift & goto CheckOpts +if '%1'=='-e' call "%dir%get_externals.bat" & shift & goto CheckOpts -if "%platf%"=="x64" (set vs_platf=x86_amd64) +if '%platf%'=='x64' (set vs_platf=x86_amd64) rem Setup the environment call "%VS100COMNTOOLS%..\..\VC\vcvarsall.bat" %vs_platf% |