diff options
author | Pablo Galindo <Pablogsal@gmail.com> | 2021-05-21 15:09:51 (GMT) |
---|---|---|
committer | GitHub <noreply@github.com> | 2021-05-21 15:09:51 (GMT) |
commit | b51081c1a8cf01b92ba0692173e1b9274a57f455 (patch) | |
tree | c3727d9b9652471014b5eac5245177382ed41780 /Parser/pegen.c | |
parent | b11a951f16f0603d98de24fee5c023df83ea552c (diff) | |
download | cpython-b51081c1a8cf01b92ba0692173e1b9274a57f455.zip cpython-b51081c1a8cf01b92ba0692173e1b9274a57f455.tar.gz cpython-b51081c1a8cf01b92ba0692173e1b9274a57f455.tar.bz2 |
bpo-44180: Report generic syntax errors in the furthest position reached in the first parser pass (GH-26253)
Diffstat (limited to 'Parser/pegen.c')
-rw-r--r-- | Parser/pegen.c | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/Parser/pegen.c b/Parser/pegen.c index c2f2540..406c4e8 100644 --- a/Parser/pegen.c +++ b/Parser/pegen.c @@ -1281,6 +1281,7 @@ _PyPegen_run_parser(Parser *p) { void *res = _PyPegen_parse(p); if (res == NULL) { + Token *last_token = p->tokens[p->fill - 1]; reset_parser_state(p); _PyPegen_parse(p); if (PyErr_Occurred()) { @@ -1307,7 +1308,11 @@ _PyPegen_run_parser(Parser *p) RAISE_INDENTATION_ERROR("unexpected unindent"); } else { - RAISE_SYNTAX_ERROR("invalid syntax"); + // Use the last token we found on the first pass to avoid reporting + // incorrect locations for generic syntax errors just because we reached + // further away when trying to find specific syntax errors in the second + // pass. + RAISE_SYNTAX_ERROR_KNOWN_LOCATION(last_token, "invalid syntax"); // _PyPegen_check_tokenizer_errors will override the existing // generic SyntaxError we just raised if errors are found. _PyPegen_check_tokenizer_errors(p); |