diff options
author | Berker Peksag <berker.peksag@gmail.com> | 2017-07-21 23:27:17 (GMT) |
---|---|---|
committer | GitHub <noreply@github.com> | 2017-07-21 23:27:17 (GMT) |
commit | e78dc0aaf03cd98373910150c2d35418cf938254 (patch) | |
tree | 88f1c142be045beeccdcafd3f4fcdbc8ce9ff485 /Python/Python-ast.c | |
parent | bf3a1e973b49236e6f267cca135d36290568e6a4 (diff) | |
download | cpython-e78dc0aaf03cd98373910150c2d35418cf938254.zip cpython-e78dc0aaf03cd98373910150c2d35418cf938254.tar.gz cpython-e78dc0aaf03cd98373910150c2d35418cf938254.tar.bz2 |
[3.5] bpo-29403: Fix mock's broken autospec behavior on method-bound builtin functions (GH-3)
Cython will, in the right circumstances, offer a MethodType instance
where im_func is a builtin function. Any instance of MethodType is
automatically assumed to be a Python-defined function (more
specifically, a function that has an inspectable signature), but
_set_signature was still conservative in its assumptions. As a result
_set_signature would return early with None instead of a mock since
the im_func had no inspectable signature. This causes problems
deeper inside mock, as _set_signature is assumed to _always_
return a mock, and nothing checked its return value.
In similar corner cases, autospec will simply not check the spec of the
function, so _set_signature is amended to now return early with the
original, not-wrapped mock object.
Patch by Aaron Gallagher.
(cherry picked from commit 856cbcc12f2e4cca93af5dc7ed6bcea4dd942f10)
Diffstat (limited to 'Python/Python-ast.c')
0 files changed, 0 insertions, 0 deletions