diff options
| author | Miss Islington (bot) <31488909+miss-islington@users.noreply.github.com> | 2024-06-07 16:26:03 (GMT) |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-06-07 16:26:03 (GMT) |
| commit | ec7c9d330f23c99559a7f8575bf27dbdb5c4d05d (patch) | |
| tree | 66a5b607cb41ff084d26099a9c19adf90eebb1f6 /Python/Python-tokenize.c | |
| parent | b3b5278475b31713fa86eaddfcbf4f22859ce59b (diff) | |
| download | cpython-ec7c9d330f23c99559a7f8575bf27dbdb5c4d05d.zip cpython-ec7c9d330f23c99559a7f8575bf27dbdb5c4d05d.tar.gz cpython-ec7c9d330f23c99559a7f8575bf27dbdb5c4d05d.tar.bz2 | |
[3.12] gh-120155: Fix copy/paste error in HAVE_SUBOFFSETS_IN_LAST_DIM() (GH-120228) (#120240)
gh-120155: Fix copy/paste error in HAVE_SUBOFFSETS_IN_LAST_DIM() (GH-120228)
Don't hardcode 'dest' in HAVE_SUBOFFSETS_IN_LAST_DIM() macro of
memoryobject.c, but use its 'view' parameter instead.
Fix the Coverity issue:
Error: COPY_PASTE_ERROR (CWE-398):
Python-3.12.2/Objects/memoryobject.c:273:14: original: ""dest->suboffsets + (dest->ndim - 1)"" looks like the original copy.
Python-3.12.2/Objects/memoryobject.c:274:14: copy_paste_error: ""dest"" in ""src->suboffsets + (dest->ndim - 1)"" looks like a copy-paste error.
Python-3.12.2/Objects/memoryobject.c:274:14: remediation: Should it say ""src"" instead?
GH- 272| assert(dest->ndim > 0 && src->ndim > 0);
GH- 273| return (!HAVE_SUBOFFSETS_IN_LAST_DIM(dest) &&
GH- 274|-> !HAVE_SUBOFFSETS_IN_LAST_DIM(src) &&
GH- 275| dest->strides[dest->ndim-1] == dest->itemsize &&
GH- 276| src->strides[src->ndim-1] == src->itemsize);
(cherry picked from commit 90b75405260467814c93738a3325645918d4ea51)
Co-authored-by: Victor Stinner <vstinner@python.org>
Diffstat (limited to 'Python/Python-tokenize.c')
0 files changed, 0 insertions, 0 deletions