diff options
author | Pablo Galindo <Pablogsal@gmail.com> | 2020-05-15 01:04:52 (GMT) |
---|---|---|
committer | GitHub <noreply@github.com> | 2020-05-15 01:04:52 (GMT) |
commit | 16ab07063cb564c1937714bd39d6915172f005b5 (patch) | |
tree | f536d329aa196ac4755d3407a698dae48f9bb7b5 /Python/ast.c | |
parent | 7ba1f75f3f02b4b50ac6d7e17d15e467afa36aac (diff) | |
download | cpython-16ab07063cb564c1937714bd39d6915172f005b5.zip cpython-16ab07063cb564c1937714bd39d6915172f005b5.tar.gz cpython-16ab07063cb564c1937714bd39d6915172f005b5.tar.bz2 |
bpo-40334: Correctly identify invalid target in assignment errors (GH-20076)
Co-authored-by: Lysandros Nikolaou <lisandrosnik@gmail.com>
Diffstat (limited to 'Python/ast.c')
-rw-r--r-- | Python/ast.c | 13 |
1 files changed, 8 insertions, 5 deletions
diff --git a/Python/ast.c b/Python/ast.c index 1a4a311..2d20ca6 100644 --- a/Python/ast.c +++ b/Python/ast.c @@ -3164,10 +3164,7 @@ ast_for_expr_stmt(struct compiling *c, const node *n) expr1 = ast_for_testlist(c, ch); if (!expr1) return NULL; - if(!set_context(c, expr1, Store, ch)) - return NULL; - /* set_context checks that most expressions are not the left side. - Augmented assignments can only have a name, a subscript, or an + /* Augmented assignments can only have a name, a subscript, or an attribute on the left, though, so we have to explicitly check for those. */ switch (expr1->kind) { @@ -3176,10 +3173,16 @@ ast_for_expr_stmt(struct compiling *c, const node *n) case Subscript_kind: break; default: - ast_error(c, ch, "illegal expression for augmented assignment"); + ast_error(c, ch, "'%s' is an illegal expression for augmented assignment", + get_expr_name(expr1)); return NULL; } + /* set_context checks that most expressions are not the left side. */ + if(!set_context(c, expr1, Store, ch)) { + return NULL; + } + ch = CHILD(n, 2); if (TYPE(ch) == testlist) expr2 = ast_for_testlist(c, ch); |