summaryrefslogtreecommitdiffstats
path: root/Python/compile.c
diff options
context:
space:
mode:
authorMiss Islington (bot) <31488909+miss-islington@users.noreply.github.com>2019-09-06 09:14:31 (GMT)
committerVictor Stinner <vstinner@redhat.com>2019-09-06 09:14:31 (GMT)
commit4d1abedce9422473af2ac78047e55cde73208208 (patch)
tree97d44d582ded5ced53755693290f5d27375483c7 /Python/compile.c
parentb8c66779c7003071f1a330428d58bbbb34c7ae12 (diff)
downloadcpython-4d1abedce9422473af2ac78047e55cde73208208.zip
cpython-4d1abedce9422473af2ac78047e55cde73208208.tar.gz
cpython-4d1abedce9422473af2ac78047e55cde73208208.tar.bz2
bpo-37380: subprocess: don't use _active on win (GH-14360) (GH-15707)
As noted by @eryksun in [1] and [2], using _cleanup and _active(in __del__) is not necessary on Windows, since: > Unlike Unix, a process in Windows doesn't have to be waited on by > its parent to avoid a zombie. Keeping the handle open will actually > create a zombie until the next _cleanup() call, which may be never > if Popen() isn't called again. This patch simply defines `subprocess._active` as `None`, for which we already have the proper logic in place in `subprocess.Popen.__del__`, that prevents it from trying to append the process to the `_active`. This patch also defines `subprocess._cleanup` as a noop for Windows. [1] https://bugs.python.org/issue37380GH-msg346333 [2] https://bugs.python.org/issue36067GH-msg336262 Signed-off-by: Ruslan Kuprieiev <ruslan@iterative.ai> (cherry picked from commit 042821ae3cf537e01963c9ec85d1a454d921e826) Co-authored-by: Ruslan Kuprieiev <kupruser@gmail.com>
Diffstat (limited to 'Python/compile.c')
0 files changed, 0 insertions, 0 deletions