summaryrefslogtreecommitdiffstats
path: root/Python/flowgraph.c
diff options
context:
space:
mode:
authorIrit Katriel <1055913+iritkatriel@users.noreply.github.com>2023-09-22 13:27:29 (GMT)
committerGitHub <noreply@github.com>2023-09-22 13:27:29 (GMT)
commit107e14820a3d3f158c908ecec506cacd4572b402 (patch)
tree67cb29dff7054c0d8c1e6f316dabafb116ad28a9 /Python/flowgraph.c
parent92a347997ffd18862704571fdb5db25cefba4247 (diff)
downloadcpython-107e14820a3d3f158c908ecec506cacd4572b402.zip
cpython-107e14820a3d3f158c908ecec506cacd4572b402.tar.gz
cpython-107e14820a3d3f158c908ecec506cacd4572b402.tar.bz2
[3.12] gh-109627: duplicated small exit blocks need to be assigned jump target labels (#109630) (#109632)
gh-109627: duplicated smalll exit blocks need to be assigned jump target labels (#109630) (cherry picked from commit 9ccf0545efd5bc5af5aa51774030c471d49a972b)
Diffstat (limited to 'Python/flowgraph.c')
-rw-r--r--Python/flowgraph.c22
1 files changed, 17 insertions, 5 deletions
diff --git a/Python/flowgraph.c b/Python/flowgraph.c
index 4fe581b..0ea3234 100644
--- a/Python/flowgraph.c
+++ b/Python/flowgraph.c
@@ -562,16 +562,23 @@ check_cfg(cfg_builder *g) {
return SUCCESS;
}
-/* Calculate the actual jump target from the target_label */
static int
-translate_jump_labels_to_targets(basicblock *entryblock)
+get_max_label(basicblock *entryblock)
{
- int max_label = -1;
+ int lbl = -1;
for (basicblock *b = entryblock; b != NULL; b = b->b_next) {
- if (b->b_label.id > max_label) {
- max_label = b->b_label.id;
+ if (b->b_label.id > lbl) {
+ lbl = b->b_label.id;
}
}
+ return lbl;
+}
+
+/* Calculate the actual jump target from the target_label */
+static int
+translate_jump_labels_to_targets(basicblock *entryblock)
+{
+ int max_label = get_max_label(entryblock);
size_t mapsize = sizeof(basicblock *) * (max_label + 1);
basicblock **label2block = (basicblock **)PyMem_Malloc(mapsize);
if (!label2block) {
@@ -2035,6 +2042,7 @@ is_exit_without_lineno(basicblock *b) {
return true;
}
+
/* PEP 626 mandates that the f_lineno of a frame is correct
* after a frame terminates. It would be prohibitively expensive
* to continuously update the f_lineno field at runtime,
@@ -2048,6 +2056,9 @@ static int
duplicate_exits_without_lineno(cfg_builder *g)
{
assert(no_empty_basic_blocks(g));
+
+ int next_lbl = get_max_label(g->g_entryblock) + 1;
+
/* Copy all exit blocks without line number that are targets of a jump.
*/
basicblock *entryblock = g->g_entryblock;
@@ -2066,6 +2077,7 @@ duplicate_exits_without_lineno(cfg_builder *g)
target->b_predecessors--;
new_target->b_predecessors = 1;
new_target->b_next = target->b_next;
+ new_target->b_label.id = next_lbl++;
target->b_next = new_target;
}
}