summaryrefslogtreecommitdiffstats
path: root/Python/getargs.c
diff options
context:
space:
mode:
authorTim Peters <tim.peters@gmail.com>2001-10-27 05:30:17 (GMT)
committerTim Peters <tim.peters@gmail.com>2001-10-27 05:30:17 (GMT)
commit61dde63e3bdcdca9e352ec91442137e9ace5f75d (patch)
tree4c1935eddd9cb02ddc88901d66cdf4ba30287d2b /Python/getargs.c
parentb054be41c0cc5315d53c665195fecd0e977c4ff3 (diff)
downloadcpython-61dde63e3bdcdca9e352ec91442137e9ace5f75d.zip
cpython-61dde63e3bdcdca9e352ec91442137e9ace5f75d.tar.gz
cpython-61dde63e3bdcdca9e352ec91442137e9ace5f75d.tar.bz2
vgetargskeywords: Removed one of the mysterious PyErr_Clear() calls.
The "need" for this was probably removed by an earlier patch that stopped the loop right before it from passing NULL to a dict lookup routine. I still haven't convinced myself that the next loop is correct, so am leaving the next mysterious PyErr_Clear() call in for now.
Diffstat (limited to 'Python/getargs.c')
-rw-r--r--Python/getargs.c11
1 files changed, 1 insertions, 10 deletions
diff --git a/Python/getargs.c b/Python/getargs.c
index 9796b5e..a68940a 100644
--- a/Python/getargs.c
+++ b/Python/getargs.c
@@ -1099,18 +1099,9 @@ vgetargskeywords(PyObject *args, PyObject *keywords, char *format,
}
}
}
- /* XXX The loop just above didn't used to break when hitting the
- end of kwlist, so could pass NULL on to PyMapping_HasKeyString,
- which sets a "NULL argument to internal routine" error then.
- However, the comment below doesn't give any clues about which
- 'error string' it's talking about, so darned hard to say whether
- the PyErr_Clear() still serves a purpose.
- */
- PyErr_Clear(); /* I'm not which Py functions set the error string */
-
+
/* required arguments missing from args can be supplied by keyword
arguments */
-
len = nargs;
if (keywords && nargs < min) {
for (i = nargs; i < min; i++) {