summaryrefslogtreecommitdiffstats
path: root/Python/getcompiler.c
diff options
context:
space:
mode:
authorMiss Islington (bot) <31488909+miss-islington@users.noreply.github.com>2020-02-04 22:06:42 (GMT)
committerGitHub <noreply@github.com>2020-02-04 22:06:42 (GMT)
commitc352e6c7446c894b13643f538db312092b351789 (patch)
treed924f8c3d763b216e83c1db39874a0de133a107b /Python/getcompiler.c
parent51332c467ed2e07a191f903d554d0c54248e4d88 (diff)
downloadcpython-c352e6c7446c894b13643f538db312092b351789.zip
cpython-c352e6c7446c894b13643f538db312092b351789.tar.gz
cpython-c352e6c7446c894b13643f538db312092b351789.tar.bz2
closes bpo-39510: Fix use-after-free in BufferedReader.readinto() (GH-18350)
When called on a closed object, readinto() segfaults on account of a write to a freed buffer: ==220553== Process terminating with default action of signal 11 (SIGSEGV): dumping core ==220553== Access not within mapped region at address 0x2A ==220553== at 0x48408A0: memmove (vg_replace_strmem.c:1272) ==220553== by 0x58DB0C: _buffered_readinto_generic (bufferedio.c:972) ==220553== by 0x58DCBA: _io__Buffered_readinto_impl (bufferedio.c:1053) ==220553== by 0x58DCBA: _io__Buffered_readinto (bufferedio.c.h:253) Reproducer: reader = open ("/dev/zero", "rb") _void = reader.read (42) reader.close () reader.readinto (bytearray (42)) GH-GH-GH- BANG! The problem exists since 2012 when commit dc469454ec added code to free the read buffer on close(). Signed-off-by: Philipp Gesang <philipp.gesang@intra2net.com> (cherry picked from commit cb1c0746f277052e45a60d6c436a765e34722821) Co-authored-by: Philipp Gesang <phg@phi-gamma.net> Co-authored-by: Philipp Gesang <phg@phi-gamma.net>
Diffstat (limited to 'Python/getcompiler.c')
0 files changed, 0 insertions, 0 deletions