summaryrefslogtreecommitdiffstats
path: root/Python/pystate.c
diff options
context:
space:
mode:
authorStefan Krah <skrah@bytereef.org>2020-03-02 20:22:36 (GMT)
committerGitHub <noreply@github.com>2020-03-02 20:22:36 (GMT)
commitb3b9ade4a3d3fe00d933bcd8fc5c5c755d1024f9 (patch)
tree20c2b9d6a7a68e8c3d8c9bd1f0609bebcb420197 /Python/pystate.c
parent2d2f85517f8216146a2f888d1ad4d765b3be2339 (diff)
downloadcpython-b3b9ade4a3d3fe00d933bcd8fc5c5c755d1024f9.zip
cpython-b3b9ade4a3d3fe00d933bcd8fc5c5c755d1024f9.tar.gz
cpython-b3b9ade4a3d3fe00d933bcd8fc5c5c755d1024f9.tar.bz2
bpo-39776: Lock ++interp->tstate_next_unique_id. (GH-18746) (#18746)
- Threads created by PyGILState_Ensure() could have a duplicate tstate->id.
Diffstat (limited to 'Python/pystate.c')
-rw-r--r--Python/pystate.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/Python/pystate.c b/Python/pystate.c
index ebc17ea..4001c63 100644
--- a/Python/pystate.c
+++ b/Python/pystate.c
@@ -606,13 +606,12 @@ new_threadstate(PyInterpreterState *interp, int init)
tstate->context = NULL;
tstate->context_ver = 1;
- tstate->id = ++interp->tstate_next_unique_id;
-
if (init) {
_PyThreadState_Init(tstate);
}
HEAD_LOCK(runtime);
+ tstate->id = ++interp->tstate_next_unique_id;
tstate->prev = NULL;
tstate->next = interp->tstate_head;
if (tstate->next)