diff options
| author | Zane Bitter <zbitter@redhat.com> | 2017-10-17 21:29:39 (GMT) |
|---|---|---|
| committer | Serhiy Storchaka <storchaka@gmail.com> | 2017-10-17 21:29:39 (GMT) |
| commit | de86073a761cd3539aaca6f886a1f55effc0d9da (patch) | |
| tree | 8277693d0d29d8b9cbe06449c9d048fb0aadfe9b /Python/pythonrun.c | |
| parent | 191e3138200906e43cba9347177914325b54843f (diff) | |
| download | cpython-de86073a761cd3539aaca6f886a1f55effc0d9da.zip cpython-de86073a761cd3539aaca6f886a1f55effc0d9da.tar.gz cpython-de86073a761cd3539aaca6f886a1f55effc0d9da.tar.bz2 | |
bpo-28603: Fix formatting tracebacks for unhashable exceptions (#4014)
Diffstat (limited to 'Python/pythonrun.c')
| -rw-r--r-- | Python/pythonrun.c | 21 |
1 files changed, 18 insertions, 3 deletions
diff --git a/Python/pythonrun.c b/Python/pythonrun.c index df814fb..25e2da4 100644 --- a/Python/pythonrun.c +++ b/Python/pythonrun.c @@ -817,13 +817,21 @@ print_exception_recursive(PyObject *f, PyObject *value, PyObject *seen) if (seen != NULL) { /* Exception chaining */ - if (PySet_Add(seen, value) == -1) + PyObject *value_id = PyLong_FromVoidPtr(value); + if (value_id == NULL || PySet_Add(seen, value_id) == -1) PyErr_Clear(); else if (PyExceptionInstance_Check(value)) { + PyObject *check_id = NULL; cause = PyException_GetCause(value); context = PyException_GetContext(value); if (cause) { - res = PySet_Contains(seen, cause); + check_id = PyLong_FromVoidPtr(cause); + if (check_id == NULL) { + res = -1; + } else { + res = PySet_Contains(seen, check_id); + Py_DECREF(check_id); + } if (res == -1) PyErr_Clear(); if (res == 0) { @@ -835,7 +843,13 @@ print_exception_recursive(PyObject *f, PyObject *value, PyObject *seen) } else if (context && !((PyBaseExceptionObject *)value)->suppress_context) { - res = PySet_Contains(seen, context); + check_id = PyLong_FromVoidPtr(context); + if (check_id == NULL) { + res = -1; + } else { + res = PySet_Contains(seen, check_id); + Py_DECREF(check_id); + } if (res == -1) PyErr_Clear(); if (res == 0) { @@ -848,6 +862,7 @@ print_exception_recursive(PyObject *f, PyObject *value, PyObject *seen) Py_XDECREF(context); Py_XDECREF(cause); } + Py_XDECREF(value_id); } print_exception(f, value); if (err != 0) |