diff options
author | Victor Stinner <victor.stinner@gmail.com> | 2017-06-10 09:20:03 (GMT) |
---|---|---|
committer | GitHub <noreply@github.com> | 2017-06-10 09:20:03 (GMT) |
commit | 0b7629cd846e3e160ac07cafc4e97644024f11b8 (patch) | |
tree | b7c071a2735ea5ad5001587b0a69741e89acff03 /Python/random.c | |
parent | 12cbd87ac0bb826d653040044c6b526dcdb6f6d1 (diff) | |
download | cpython-0b7629cd846e3e160ac07cafc4e97644024f11b8.zip cpython-0b7629cd846e3e160ac07cafc4e97644024f11b8.tar.gz cpython-0b7629cd846e3e160ac07cafc4e97644024f11b8.tar.bz2 |
bpo-30038: fix race condition in signal delivery + wakeup fd (#1082) (#2075)
Before, it was possible to get the following sequence of
events (especially on Windows, where the C-level signal handler for
SIGINT is run in a separate thread):
- SIGINT arrives
- trip_signal is called
- trip_signal writes to the wakeup fd
- the main thread wakes up from select()-or-equivalent
- the main thread checks for pending signals, but doesn't see any
- the main thread drains the wakeup fd
- the main thread goes back to sleep
- trip_signal sets is_tripped=1 and calls Py_AddPendingCall to notify
the main thread the it should run the Python-level signal handler
- the main thread doesn't notice because it's asleep
This has been causing repeated failures in the Trio test suite:
https://github.com/python-trio/trio/issues/119
(cherry picked from commit 4ae01496971624c75080431806ed1c08e00f22c7)
Diffstat (limited to 'Python/random.c')
0 files changed, 0 insertions, 0 deletions