summaryrefslogtreecommitdiffstats
path: root/Python/symtable.c
diff options
context:
space:
mode:
authorCarl Meyer <carl@oddbird.net>2024-02-07 16:56:16 (GMT)
committerGitHub <noreply@github.com>2024-02-07 16:56:16 (GMT)
commitfedbf77191ea9d6515b39f958cc9e588d23517c9 (patch)
treecd4941e9d79c8a6cc4f3e4d86d7ffa46a7f5694a /Python/symtable.c
parent8a3c499ffe7e15297dd4c0b446a0b97b4d32108a (diff)
downloadcpython-fedbf77191ea9d6515b39f958cc9e588d23517c9.zip
cpython-fedbf77191ea9d6515b39f958cc9e588d23517c9.tar.gz
cpython-fedbf77191ea9d6515b39f958cc9e588d23517c9.tar.bz2
gh-114828: Fix __class__ in class-scope inlined comprehensions (#115139)
Diffstat (limited to 'Python/symtable.c')
-rw-r--r--Python/symtable.c19
1 files changed, 19 insertions, 0 deletions
diff --git a/Python/symtable.c b/Python/symtable.c
index 7430299..d695163 100644
--- a/Python/symtable.c
+++ b/Python/symtable.c
@@ -758,6 +758,8 @@ inline_comprehension(PySTEntryObject *ste, PySTEntryObject *comp,
{
PyObject *k, *v;
Py_ssize_t pos = 0;
+ int remove_dunder_class = 0;
+
while (PyDict_Next(comp->ste_symbols, &pos, &k, &v)) {
// skip comprehension parameter
long comp_flags = PyLong_AS_LONG(v);
@@ -779,6 +781,19 @@ inline_comprehension(PySTEntryObject *ste, PySTEntryObject *comp,
if (!existing) {
// name does not exist in scope, copy from comprehension
assert(scope != FREE || PySet_Contains(comp_free, k) == 1);
+ if (scope == FREE && ste->ste_type == ClassBlock &&
+ _PyUnicode_EqualToASCIIString(k, "__class__")) {
+ // if __class__ is unbound in the enclosing class scope and free
+ // in the comprehension scope, it needs special handling; just
+ // letting it be marked as free in class scope will break due to
+ // drop_class_free
+ scope = GLOBAL_IMPLICIT;
+ only_flags &= ~DEF_FREE;
+ if (PySet_Discard(comp_free, k) < 0) {
+ return 0;
+ }
+ remove_dunder_class = 1;
+ }
PyObject *v_flags = PyLong_FromLong(only_flags);
if (v_flags == NULL) {
return 0;
@@ -803,6 +818,10 @@ inline_comprehension(PySTEntryObject *ste, PySTEntryObject *comp,
}
}
}
+ comp->ste_free = PySet_Size(comp_free) > 0;
+ if (remove_dunder_class && PyDict_DelItemString(comp->ste_symbols, "__class__") < 0) {
+ return 0;
+ }
return 1;
}