diff options
| author | Miss Islington (bot) <31488909+miss-islington@users.noreply.github.com> | 2018-12-08 14:34:49 (GMT) |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2018-12-08 14:34:49 (GMT) |
| commit | 8b7d8ac09cc0f736d0c3a39d838814d7ae253021 (patch) | |
| tree | 5e80bc867b3006ae65fe88bba33b285072b7acea /Python/sysmodule.c | |
| parent | ee2c5a8e2dcf662048dbcf4e49af9b4aaf81f7d3 (diff) | |
| download | cpython-8b7d8ac09cc0f736d0c3a39d838814d7ae253021.zip cpython-8b7d8ac09cc0f736d0c3a39d838814d7ae253021.tar.gz cpython-8b7d8ac09cc0f736d0c3a39d838814d7ae253021.tar.bz2 | |
bpo-35441: Remove dead and buggy code related to PyList_SetItem(). (GH-11033)
In _localemodule.c and selectmodule.c, remove dead code that would
cause double decrefs if run.
In addition, replace PyList_SetItem() with PyList_SET_ITEM() in cases
where a new list is populated and there is no possibility of an error.
In addition, check if the list changed size in the loop in array_array_fromlist().
(cherry picked from commit 99d56b53560b3867844472ae381fb3f858760621)
Co-authored-by: Zackery Spytz <zspytz@gmail.com>
Diffstat (limited to 'Python/sysmodule.c')
| -rw-r--r-- | Python/sysmodule.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/Python/sysmodule.c b/Python/sysmodule.c index 498fa91..f04403b 100644 --- a/Python/sysmodule.c +++ b/Python/sysmodule.c @@ -2544,7 +2544,7 @@ makepathobject(const wchar_t *path, wchar_t delim) Py_DECREF(v); return NULL; } - PyList_SetItem(v, i, w); + PyList_SET_ITEM(v, i, w); if (*p == '\0') break; path = p+1; |