summaryrefslogtreecommitdiffstats
path: root/Python/thread_pthread.h
diff options
context:
space:
mode:
authorVictor Stinner <victor.stinner@gmail.com>2013-12-13 10:08:56 (GMT)
committerVictor Stinner <victor.stinner@gmail.com>2013-12-13 10:08:56 (GMT)
commit590cebe391fb2e199afe9b20ff67e360116a1266 (patch)
tree4adb2f6536cb319f479fbb2de06644f2ca32326d /Python/thread_pthread.h
parentcb1c4c8c22e27f0f7a01e1bb5ad78a804cf17c07 (diff)
downloadcpython-590cebe391fb2e199afe9b20ff67e360116a1266.zip
cpython-590cebe391fb2e199afe9b20ff67e360116a1266.tar.gz
cpython-590cebe391fb2e199afe9b20ff67e360116a1266.tar.bz2
Issue #19787: PyThread_set_key_value() now always set the value
In Python 3.3, PyThread_set_key_value() did nothing if the key already exists (if the current value is a non-NULL pointer). When _PyGILState_NoteThreadState() is called twice on the same thread with a different Python thread state, it still keeps the old Python thread state to keep the old behaviour. Replacing the Python thread state with the new state introduces new bugs: see issues #10915 and #15751.
Diffstat (limited to 'Python/thread_pthread.h')
-rw-r--r--Python/thread_pthread.h3
1 files changed, 0 insertions, 3 deletions
diff --git a/Python/thread_pthread.h b/Python/thread_pthread.h
index 20f8535..d9f7c76 100644
--- a/Python/thread_pthread.h
+++ b/Python/thread_pthread.h
@@ -627,9 +627,6 @@ int
PyThread_set_key_value(int key, void *value)
{
int fail;
- void *oldValue = pthread_getspecific(key);
- if (oldValue != NULL)
- return 0;
fail = pthread_setspecific(key, value);
return fail ? -1 : 0;
}